refactor: use TALXIS.Platform.Metadata.Packaging library for solution pack/unpack#80
Merged
Merged
Conversation
Replace the local SolutionPackager wrapper with TALXIS.Platform.Metadata.Packaging 0.7.0 in CLI pack, unpack, import, and export paths. - remove the local ISolutionPackagerService contract and implementation - register the shared packaging service from the package - update CLI commands and export service to use the package API - keep TALXIS.Platform.Metadata.Serialization.Xml alongside the new packaging reference in Features.Environment Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
TomProkop
force-pushed
the
feature/use-packaging-library
branch
from
455e684 to
5c81328
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors txc solution pack/unpack (and related import/export paths) to use the published TALXIS.Platform.Metadata.Packaging library instead of the repo’s local SolutionPackagerLib wrapper and Core contract.
Changes:
- Replace the repo-local
ISolutionPackagerServicecontract +SolutionPackagerServiceImplwrapper withTALXIS.Platform.Metadata.Packaging’sISolutionPackagerService/SolutionPackagerService. - Update DI to resolve the packager service from the shared packaging package.
- Update CLI command code to reference the shared packaging API namespace and add required package references.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/TALXIS.CLI.Platform.Dataverse.Application/TALXIS.CLI.Platform.Dataverse.Application.csproj | Removes SolutionPackagerLib reference plumbing; adds TALXIS.Platform.Metadata.Packaging package dependency. |
| src/TALXIS.CLI.Platform.Dataverse.Application/Services/DataverseSolutionExportService.cs | Switches packager service type resolution to the shared packaging namespace. |
| src/TALXIS.CLI.Platform.Dataverse.Application/Sdk/SolutionPackagerService.cs | Deletes the local SolutionPackagerLib wrapper implementation. |
| src/TALXIS.CLI.Platform.Dataverse.Application/DependencyInjection/DataverseApplicationServiceCollectionExtensions.cs | Updates DI registration to use SolutionPackagerService from the shared packaging package. |
| src/TALXIS.CLI.Features.Environment/TALXIS.CLI.Features.Environment.csproj | Adds TALXIS.Platform.Metadata.Packaging package dependency for CLI commands using the packager service. |
| src/TALXIS.CLI.Features.Environment/Solution/SolutionUnpackCliCommand.cs | Updates packager service namespace import to the shared packaging package. |
| src/TALXIS.CLI.Features.Environment/Solution/SolutionPackCliCommand.cs | Updates packager service namespace import to the shared packaging package. |
| src/TALXIS.CLI.Features.Environment/Solution/SolutionImportCliCommand.cs | Imports the shared packaging namespace to resolve ISolutionPackagerService. |
| src/TALXIS.CLI.Core/Contracts/Dataverse/ISolutionPackagerService.cs | Removes the repo-local packager service contract now provided by the shared packaging package. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Switches
tools-clisolution pack/unpack flows from the local inlineSolutionPackagerLibwrapper to the published TALXIS.Platform.Metadata.Packaging package.Depends on
TALXIS/platform-metadatav0.7.0(published) — providesTALXIS.Platform.Metadata.Packaging0.7.0Changes
ISolutionPackagerServicecontract fromTALXIS.CLI.CoreSolutionPackagerServiceimplementation fromTALXIS.CLI.Platform.Dataverse.ApplicationTALXIS.Platform.Metadata.Packaging0.7.0package references to:TALXIS.CLI.Platform.Dataverse.ApplicationTALXIS.CLI.Features.EnvironmentTALXIS.Platform.Metadata.Serialization.XmlinTALXIS.CLI.Features.Environmentalongside the new packaging package referenceSolutionPackagerServicefrom the published packagepack,unpack,import, and export/unpack paths to use the shared package APIValidation
masterdotnet build TALXIS.CLI.sln -c Releasedotnet test TALXIS.CLI.sln -c Release --no-buildenvironment solution pack->environment solution unpackon a minimal valid solution workspace