Skip to content

Fix duplicate legacy paypal action created on create #3124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Crabcyborg merged 1 commit into from
Jun 5, 2026
Merged

Fix duplicate legacy paypal action created on create #3124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions classes/views/frm-form-actions/default_actions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,12 @@ public function __construct() {
$this->id_base = 'paypal-legacy';
$this->name = 'PayPal (Legacy)';

// FrmPaymentAction sets option_name to 'frm_paypal_action' using its 'paypal'
// id_base. Recompute it from the new id_base so this action does not share the
// POST data namespace with the PayPal add-on's 'paypal' action, which would make
// both action controls save the same submission and create a duplicate action.
$this->option_name = 'frm_' . $this->id_base . '_action';
Copy link
Copy Markdown

@deepsource-io deepsource-io Bot Jun 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Access to an undefined property FrmDefPayPalLegacyAction::$option_name


This issue is raised when an attempt is made to access an undefined property.
This may not have been intended, and it is advisable to give the code another look to make sure the property is defined in the scope it is used in.


$this->action_options['is_beta'] = false;
}
}
Expand Down
Loading