EBP-2375: .NET serdes provider json schema references snippets#66
Draft
TrentDaniel wants to merge 1 commit into
Draft
EBP-2375: .NET serdes provider json schema references snippets#66TrentDaniel wants to merge 1 commit into
TrentDaniel wants to merge 1 commit into
Conversation
…ze and deserialize withn references, explicit schema versions, and latest schema version
aelsammak
reviewed
Jun 18, 2026
| /// <list type="bullet"> | ||
| /// <item>SerializeWithUserJsonSchema - Basic serialization with User POCO</item> | ||
| /// <item>SerializeWithJsonNode - Serialization with JsonNode object</item> | ||
| /// <item>SerializeWithFindLatest - Serialization with find-latest-artifact resolver strategy</item> |
There was a problem hiding this comment.
Calling the find-latest-artifact boolean property a resolver strategy is misleading and can make users think it is an ArtifactResolverStrategy. We should fix this to be "find-latest schema resolver option"
aelsammak
reviewed
Jun 18, 2026
| config[JsonSchemaPropertyKeys.FindLatestArtifact] = true; | ||
|
|
||
| // Create UserAccount object with nested User | ||
| var userAccount = new UserAccount |
There was a problem hiding this comment.
Both the explicit version and find latest snippets should be using the User schema, not the UserAccount schema with references so that way we can narrow down the scope of what this snippet is trying to show. The java samples use the User schema as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated snippets file to include examples of how to serialize and deserialize withn references, explicit schema versions, and latest schema version.