docs(claude): add Promise.race handler-stacking rule#1241
Open
John-David Dalton (jdalton) wants to merge 1 commit intomainfrom
Open
docs(claude): add Promise.race handler-stacking rule#1241John-David Dalton (jdalton) wants to merge 1 commit intomainfrom
John-David Dalton (jdalton) wants to merge 1 commit intomainfrom
Conversation
Documents the leak anti-pattern so future concurrency code in socket-cli does not reintroduce it. See nodejs/node#17469. Prompted by fixes in sibling repos (socket-sdk-js #600, socket-lib #184) where the pattern had crept in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Promise.race/Promise.anyhandler-stacking anti-pattern described in nodejs/node#17469 and @watchable/unpromise.Test plan
Note
Low Risk
Docs-only change in
CLAUDE.md; no runtime or behavioral impact beyond updated engineering guidance.Overview
Adds a new SHARED STANDARDS guideline in
CLAUDE.mdwarning against usingPromise.race/Promise.anywith long-lived promises inside loops due to accumulating.thenhandlers, and recommends safer concurrency-limiter signaling patterns (with references to nodejs/node#17469 and@watchable/unpromise).Reviewed by Cursor Bugbot for commit c89ed2e. Configure here.