feat: diary entry import functionality#34
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a diary entry import/export feature to MarkDay, enabling users to back up entries as sync-compatible text files and restore them later via the Settings diagnostics UI, with platform-specific availability gating.
Changes:
- Added core import preview/apply logic for sync-compatible diary entry files, including conflict/duplicate handling.
- Integrated an “Import Diary Entries” flow into Settings > Diagnostics, including a conflict resolution dialog and import result messaging.
- Added platform-specific import availability (
expect/actual) and documented the feature in the README, plus common tests for import behavior.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Documents the new import/export feature, UX location, and file naming convention. |
| composeApp/src/commonMain/kotlin/io/github/smiling_pixel/sync/DiaryEntryImportAvailability.kt | Introduces expect API for platform availability checks. |
| composeApp/src/androidMain/kotlin/io/github/smiling_pixel/sync/DiaryEntryImportAvailability.android.kt | Enables import availability on Android. |
| composeApp/src/jvmMain/kotlin/io/github/smiling_pixel/sync/DiaryEntryImportAvailability.jvm.kt | Enables import availability on Desktop (JVM). |
| composeApp/src/wasmJsMain/kotlin/io/github/smiling_pixel/sync/DiaryEntryImportAvailability.wasmJs.kt | Disables import availability on Web (Wasm). |
| composeApp/src/commonMain/kotlin/io/github/smiling_pixel/sync/DiaryEntryImport.kt | Implements import file model + preview/apply import logic (new entries, conflicts, invalids, duplicates). |
| composeApp/src/commonMain/kotlin/io/github/smiling_pixel/screens/SettingsScreen.kt | Adds import UI wiring (file picker, preview, conflict dialog, diagnostics messaging). |
| composeApp/src/commonTest/kotlin/io/github/smiling_pixel/sync/DiaryEntryImportTest.kt | Adds tests covering preview/apply behavior (invalid files, conflicts, duplicates, mixed batches). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a comprehensive diary entry import and export feature, allowing users to back up and restore their entries using local text files. The main changes include new import/export UI in the settings, core import/export logic, and platform-specific support detection.