fix: remove unused python-dotenv dependency#63
Open
micaelaw wants to merge 1 commit intoShipEngine:mainfrom
Open
fix: remove unused python-dotenv dependency#63micaelaw wants to merge 1 commit intoShipEngine:mainfrom
micaelaw wants to merge 1 commit intoShipEngine:mainfrom
Conversation
python-dotenv was declared as a runtime dependency but is never imported or used anywhere in the package. Removing it reduces unnecessary overhead for downstream consumers. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
python-dotenvis declared as a runtime dependency inpyproject.tomlbut is never imported or used anywhere in the package. This removes it frompyproject.toml,requirements.txt, and regeneratespoetry.lock.Two motivations:
fix:commit should give release-please a properly formatted conventional commit to parse, triggering a new release PR. The previous 2.1.0 bump never made it to PyPI because my merge commits didn't follow the Conventional Commits format, so release-please silently skipped them.