Skip to content

Position Encoding Fix #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
beshirdel wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −2
Open

Position Encoding Fix #71

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Jupyter_Notebooks/Chapter_05_Natural_Language_Processing/02-Attention.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -895,7 +895,8 @@
" # PEpos + k can be represented as a linear function of PEpos.\n",
" pe[:, 0::2] = torch.sin(position * div_term)\n",
" pe[:, 1::2] = torch.cos(position * div_term)\n",
" pe = pe.unsqueeze(0).transpose(0, 1)\n",
" # pe = pe.unsqueeze(0).transpose(0, 1)\n",
" pe = pe.unsqueeze(0)\n",
" self.register_buffer('pe', pe)\n",
"\n",
" def forward(self, x):\n",
Expand All @@ -910,7 +911,7 @@
" x: Tensor\n",
" Output is of the same shape as input with dropout and positional encodings\n",
" \"\"\"\n",
" x = x + self.pe[:x.size(0), :]\n",
" x = x + self.pe[0,:x.size(1), :]\n",
" return self.dropout(x)"
]
},
Expand Down