Skip to content

Add guidance doc for property pane custom control theme implementation#10869

Merged
andrewconnell merged 6 commits into
SharePoint:mainfrom
sunyd0112:user/yidansun/addNeutralThemeDoc
Jun 1, 2026
Merged

Add guidance doc for property pane custom control theme implementation#10869
andrewconnell merged 6 commits into
SharePoint:mainfrom
sunyd0112:user/yidansun/addNeutralThemeDoc

Conversation

@sunyd0112
Copy link
Copy Markdown
Contributor

Category

  • Content fix
  • New article

What's in this Pull Request?

Adds new guidance documentation for implementing theme support in property pane custom controls:

  • New: docs/spfx/web-parts/guidance/property-pane-theme-principles.md — guidance doc on theme implementation principles for custom property pane controls.
  • Updated: docs/spfx/web-parts/guidance/build-custom-property-pane-controls.md — cross-link to the new guidance.
  • Updated: docs/toc.yml — TOC entry for the new article.

Notes

This supersedes draft PR #10635, which could not be reopened after the branch was rebased onto the latest main (GitHub blocks reopening a closed PR whose head branch was force-pushed). The branch has been synced with the latest main; the diff is limited to the three files above.

@learn-build-service-prod
Copy link
Copy Markdown
Contributor

PoliCheck Scan Report

The following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans.

✅ No issues found

More information about PoliCheck

Information: PoliCheck | Severity Guidance | Term
For any questions: Try searching the learn.microsoft.com contributor guides or post your question in the Learn support channel.

@learn-build-service-prod
Copy link
Copy Markdown
Contributor

Learn Build status updates of commit fa4704c:

✅ Validation status: passed

File Status Preview URL Details
docs/spfx/web-parts/guidance/build-custom-property-pane-controls.md ✅Succeeded View
docs/spfx/web-parts/guidance/property-pane-theme-principles.md ✅Succeeded View
docs/toc.yml ✅Succeeded View

For more details, please refer to the build report.

@sunyd0112 sunyd0112 changed the title [Do not merge] Draft guidance doc for property pane custom control theme implementation Add guidance doc for property pane custom control theme implementation Jun 1, 2026
@learn-build-service-prod
Copy link
Copy Markdown
Contributor

Learn Build status updates of commit e01aa1a:

✅ Validation status: passed

File Status Preview URL Details
docs/spfx/web-parts/guidance/build-custom-property-pane-controls.md ✅Succeeded View
docs/spfx/web-parts/guidance/property-pane-theme-principles.md ✅Succeeded View
docs/toc.yml ✅Succeeded View

For more details, please refer to the build report.

@learn-build-service-prod
Copy link
Copy Markdown
Contributor

PoliCheck Scan Report

The following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans.

✅ No issues found

More information about PoliCheck

Information: PoliCheck | Severity Guidance | Term
For any questions: Try searching the learn.microsoft.com contributor guides or post your question in the Learn support channel.

@sunyd0112
Copy link
Copy Markdown
Contributor Author

@sunyd0112 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree company="Microsoft"

@sunyd0112 sunyd0112 marked this pull request as ready for review June 1, 2026 03:24
@andrewconnell andrewconnell self-assigned this Jun 1, 2026
@andrewconnell andrewconnell added the pr:in-review Actively reviewing pull request label Jun 1, 2026
@andrewconnell andrewconnell self-requested a review June 1, 2026 22:19
…ing guidance

- collapse double blank lines flagged by formatter
- use contractions for clearer, more conversational tone
- replace e.g. with for example for accessibility
- soften strongly encouraged to encouraged
@learn-build-service-prod
Copy link
Copy Markdown
Contributor

PoliCheck Scan Report

The following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans.

✅ No issues found

More information about PoliCheck

Information: PoliCheck | Severity Guidance | Term
For any questions: Try searching the learn.microsoft.com contributor guides or post your question in the Learn support channel.

@learn-build-service-prod
Copy link
Copy Markdown
Contributor

Learn Build status updates of commit 5f0cff0:

✅ Validation status: passed

File Status Preview URL Details
docs/spfx/web-parts/guidance/build-custom-property-pane-controls.md ✅Succeeded View
docs/spfx/web-parts/guidance/property-pane-theme-principles.md ✅Succeeded View
docs/toc.yml ✅Succeeded View

For more details, please refer to the build report.

@andrewconnell andrewconnell added pr:ready-to-merge Ready to merge PR and removed pr:in-review Actively reviewing pull request labels Jun 1, 2026
@andrewconnell andrewconnell merged commit 9f0ae1f into SharePoint:main Jun 1, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:ready-to-merge Ready to merge PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants