Update metadata and add deprecation note for doc#10863
Conversation
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit 6715bed: ✅ Validation status: passed
For more details, please refer to the build report. |
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit 7eb7d3d: ✅ Validation status: passed
For more details, please refer to the build report. |
|
Learn Build status updates of commit aadda4b: ✅ Validation status: passed
For more details, please refer to the build report. |
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit 8ec64a4: ✅ Validation status: passed
For more details, please refer to the build report. |
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit 4ca0d3b: ✅ Validation status: passed
For more details, please refer to the build report. |
andrewconnell
left a comment
andrewconnell
left a comment
There was a problem hiding this comment.
If we're refreshing content, please address all MSLearn formatting rules.
| > A people picker with claims picking functionality is sometimes referred to as a claims picker. For more information, see [People picker and claims provider planning](/previous-versions/office/sharepoint-foundation-2010/gg602063(v=office.14)). | ||
|
|
||
| To write a claims provider, your first step is to create a class that derives from the **SPClaimProvider** class. | ||
| > **Tip:** |
There was a problem hiding this comment.
Incorrect use of tip... should be MSLearn callout
|
|
||
|
|
||
|
|
||
| #### Other resources |
There was a problem hiding this comment.
These should follow the same format the docs follow:
- use "See Also"
- shoudl be bullet list
|
|
||
|
|
||
| 8. You should see the following code in the Class1.cs file: | ||
| 1. Start Visual Studio. |
There was a problem hiding this comment.
Numbered bullet points should always use 1. & let the rendering engine apply the correct numbers.
|
|
||
|
|
||
|
|
||
| 2. In the **Add Reference** dialog box, on the **.NET** tab, select **Excel Services UDF Framework**. |
There was a problem hiding this comment.
Incorrect numbered list mnarkdown format used
| 1. Creates a **SimpleJob** object, which inherits from the [OfficeDevPnP.Core.Framework.TimerJobs.TimerJob](https://github.com/pnp/PnP-Sites-Core/blob/master/Core/OfficeDevPnP.Core/Framework/TimerJobs/TimerJob.cs) base class. | ||
|
|
||
| 2. Sets the Office 365 user credentials to use when running the timer job by using **TimerJob.UseOffice365Authentication**. The user credentials must have appropriate access to the site collections. You can learn more at [Authentication](timerjob-framework.md#authentication). | ||
| 2. Sets the Microsoft 365 user credentials to use when running the timer job by using **TimerJob.UseOffice365Authentication**. The user credentials must have appropriate access to the site collections. You can learn more at [Authentication](timerjob-framework.md#authentication). |
There was a problem hiding this comment.
Incorrect numbered bullet used
| 1. Gets the number of administrators assigned to the site collection by using the extension method [GetAdministrators](https://github.com/pnp/PnP-Sites-Core/blob/master/Core/OfficeDevPnP.Core/Extensions/SecurityExtensions.cs) which is part of [OfficeDevPnP.Core](https://github.com/pnp/PnP-Sites-Core/tree/master/Core/OfficeDevPnP.Core). | ||
|
|
||
| 2. Uploads the JavaScript file to the SiteAssets or Style Library list by using [UploadFile](https://github.com/SharePoint/PnP-Sites-Core/blob/master/Core/OfficeDevPnP.Core/Extensions/FileFolderExtensions.cs), which is part of [OfficeDevPnP.Core](https://github.com/SharePoint/PnP-Sites-Core/tree/master/Core/OfficeDevPnP.Core). | ||
| 2. Uploads the JavaScript file to the SiteAssets or Style Library list by using [UploadFile](https://github.com/pnp/PnP-Sites-Core/blob/master/Core/OfficeDevPnP.Core/Extensions/FileFolderExtensions.cs), which is part of [OfficeDevPnP.Core](https://github.com/pnp/PnP-Sites-Core/tree/master/Core/OfficeDevPnP.Core). |
There was a problem hiding this comment.
incorrect numbered list format
andrewconnell
left a comment
andrewconnell
left a comment
There was a problem hiding this comment.
In addition to the inline comments, multiple files have the following issues in this PR:
- Remove extra line breaks... shouldn't have more than 1 blank line
andrewconnell
added
Needs: Author Feedback
- collapse consecutive blank lines in body - normalize list marker gutters - collapse double spaces in prose - clean fenced code blocks; strip blank-line padding and left-align sibling declarations - revert `ms.date` to original publication date; rendering engine shows last modified date dynamically from git history
- collapse consecutive blank lines in body - strip trailing whitespace - collapse double spaces in prose - clean fenced code blocks; strip blank-line padding, left-align, and normalize indentation - revert `ms.date` to original publication date; rendering engine shows last modified date dynamically from git history
- collapse consecutive blank lines in body - normalize ordered list markers and gutters - strip trailing whitespace - clean fenced code blocks; strip leading blank lines and normalize indentation - revert `ms.date` to original publication date; rendering engine shows last modified date dynamically from git history
- collapse consecutive blank lines in body - normalize list markers and collapse inter-item blank lines - strip trailing whitespace - clean fenced code blocks; left-align and normalize indentation - revert `ms.date` to original publication date; rendering engine shows last modified date dynamically from git history
- collapse double spaces in prose - revert `ms.date` to original publication date; rendering engine shows last modified date dynamically from git history
|
Learn Build status updates of commit 77fea54: ✅ Validation status: passed
For more details, please refer to the build report. |
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
andrewconnell
added
pr:ready-to-merge
2 participants
Category
Related issues
-fixes SPFx Docs Update for content: docs/general-development/how-to-create-a-claims-provider-in-sharepoint.md #10862
What's in this Pull Request?
Updating docs to latest links and adding deprecation notes