Skip to content

feat(huri): kube local example with TTS + EMAGE + RAG#33

Open
bernTP wants to merge 35 commits into
devfrom
tpm/#32/tts-gesture-rag
Open

feat(huri): kube local example with TTS + EMAGE + RAG#33
bernTP wants to merge 35 commits into
devfrom
tpm/#32/tts-gesture-rag

Conversation

@bernTP

@bernTP bernTP commented May 26, 2026

Copy link
Copy Markdown

No description provided.

@bernTP bernTP changed the title Tpm/#32/tts gesture rag feat(huri): kube local example with TTS + EMAGE + RAG May 26, 2026
bernTP added 22 commits May 27, 2026 02:13

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pourquoi pas créer plusieurs fichier ou alors réorganiser pour avoir une partie seulement class et une partie seulement function

# pass pays the costs, the second confirms the path is hot), and
# synchronize so the GPU work is finished before we report ready.
# Best-effort: a failure here must never prevent the deployment coming up.
import time

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import plutot au début du fichier

gpu_mem_fraction: float = _GPU_MEM_FRACTION,
):
print(f"[Gesture] importing torch...", flush=True)
import torch

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import plutot au début du fichier


def infer(self, audio_np: np.ndarray, source_sr: int = _EMAGE_SR) -> Motion:
import torch
import torch.nn.functional as F

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import plutot au début du fichier

import torch.nn.functional as F

if source_sr != _EMAGE_SR:
import librosa

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import plutot au début du fichier

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pareille, import plutot au début du fichier

Comment thread src/modules/rag/rag.py

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import plutot au début du fichier

Comment thread src/modules/modules.py Outdated
# The following imports may contain modules with custom dependencies, depending on the Dockerfile
# CPU doesn't need some dependencies, nor the AMD that isn't compatible
try:
from src.modules.text_to_speech.text_to_speech import TTS

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je comprend pourquoi changer de fassons de faire mais pourquoi soit ne pas prendre l'ancienne, soit tout changer dans ce format ?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(je supprime ce commantaire plus tard) mais regarde mes messages STP

@MatthiasvonRakowski MatthiasvonRakowski left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai laissé quelques commentaires surtout sur les déclaration d'importe dans les function à titre personnel je ne trouve pas ça bien cat tu ne sais pas en entrant dans le fichier de quoi tu vas avoir besoin venant de endehors de ce fichier. Dans certain cas ça se justify, mais je préfèrerai mettre les imports, même celle qui sont en if - else, au début des fichier. Le reste me parrait bon, bravo super boulot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants