fix(dsv4): gate h200 reasoning parser flag#1263
Open
OCWC22 wants to merge 5 commits intoSemiAnalysisAI:mainfrom
Open
fix(dsv4): gate h200 reasoning parser flag#1263OCWC22 wants to merge 5 commits intoSemiAnalysisAI:mainfrom
OCWC22 wants to merge 5 commits intoSemiAnalysisAI:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR keeps the DeepSeek-V4 H200 single-node launcher stable by disabling the vLLM DeepSeek-V4 reasoning parser by default, while preserving an opt-in path via an environment flag.
Changes:
- Introduces
ENABLE_DSV4_REASONING_PARSER(defaultfalse) to control whether--reasoning-parser deepseek_v4is passed tovllm serve. - Refactors the reasoning-parser CLI arg into an optional Bash array so the argument is omitted cleanly when disabled.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--reasoning-parser deepseek_v4flag behindENABLE_DSV4_REASONING_PARSER=truedocs/AGENTIC_TEST_RESULTS.mdrecordsdsv4-fp8-h200-vllmas ❌ FAILED with the DeepSeek-V4 reasoning parser issue (reasoning_start_str/reasoning_end_strmissing)Smoke test
bash -n benchmarks/single_node/dsv4_fp8_h200.shpassesENABLE_DSV4_REASONING_PARSERexpansion leavesREASONING_PARSER_ARGSempty, so the launcher omits--reasoning-parser deepseek_v4unless explicitly enabled