SA-308: add inline Search button to search bar#912
Open
gbolahan507 wants to merge 1 commit into
Open
Conversation
Contributor
|
I guess I'm not wholly convinced by the UI which is not your fault, as that's what was in the ticket from the user. I can't figure out how to get to the Search button when using Talkback - you can't actually swipe to get there when the keyboard is displayed and the only way I can close the keyboard is to hit Search. The only way to get Search is to find it with your finger ('explore' with Talkback on). I'm wondering if iPhone works differently with Search? I'd like to see some other examples of a Search button like this. Having said all that, I wouldn't have known this if we didn't have the code to try, so it's useful effort. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TextButtoninside the search bar, between the text input and the ✕ clear button, as an alternative way to start a search (per SA-308).triggerSearch()lambda, so behaviour is identical and the existing flow is preserved.Changes
components/MainSearchBar.kt— extracted sharedtriggerSearchlambda; addedTextButtonin the search header row.res/values/strings.xml— new stringsearch_button_labelfor the button label.Test plan