Skip to content

fix: restore dark/light theme toggle functionality#233

Merged
SamXop123 merged 2 commits into
SamXop123:mainfrom
Akshu121796:fix/theme-toggle
Jul 10, 2026
Merged

fix: restore dark/light theme toggle functionality#233
SamXop123 merged 2 commits into
SamXop123:mainfrom
Akshu121796:fix/theme-toggle

Conversation

@Akshu121796

Copy link
Copy Markdown
Contributor

Description

This PR fixes the dark/light theme toggle not switching the application theme.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Changes Made

  • Removed the unintended dependency between the website theme toggle and the recent/favorite themes feature.
  • Restored immediate dark/light theme switching.
  • Preserved theme preference across page reloads.
  • Ensured Favorites and Recent Themes continue to function independently.

Testing

  • Tested manually

Manual Verification

  • Verified dark/light theme switches immediately on toggle.
  • Verified selected theme persists after page refresh.
  • Verified no JavaScript runtime errors occur.
  • Verified Favorites and Recent Themes continue working correctly.

Screenshots

  1. Light-theme enabled.
Screenshot 2026-07-08 010830

Checklist

  • My code follows the project's code style
  • I have performed a self-review of my code
  • My changes generate no new warnings or errors
  • My changes are scoped to a single issue

Related Issue

Closes #228

@vercel

vercel Bot commented Jul 7, 2026

Copy link
Copy Markdown

@Akshu121796 is attempting to deploy a commit to the Dot_NotSam's projects Team on Vercel.

A member of the Team first needs to authorize it.

@Akshu121796

Copy link
Copy Markdown
Contributor Author

Hi @SamXop123,
Implemented the fix for this issue.

If no change,Kindly add the appropriate GSSoC labels if required:

  • gssoc:approved
  • type:bug
  • good first issue
  • level-2

Looking forward to your review. Thank you!

@SamXop123 SamXop123 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work @Akshu121796

just one thing, please cleanup those console logs to reduce the clutter.
after that it would be good to merge

@Akshu121796

Copy link
Copy Markdown
Contributor Author

@SamXop123
Heyy, I have cleared the logs.
If no issues, PLease merge it!
Thankyou!!

@SamXop123 SamXop123 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for the contribution.

@SamXop123 SamXop123 merged commit a189f31 into SamXop123:main Jul 10, 2026
2 of 3 checks passed
@github-actions

Copy link
Copy Markdown

🎉 Congratulations @Akshu121796! 🎉

Your pull request has been successfully merged into samdev-pulse! Thank you so much for your valuable contribution and effort. Every single improvement helps make samdev-pulse a better profile experience for everyone! 🙌

🚀 What's Next?

  • Keep the momentum going! Feel free to browse through our open Issues and grab another one that interests you!
  • Support the Project: If you enjoyed contributing to samdev-pulse, please take a second to star our repository! It helps increase the project's visibility and supports our community. ⭐

💬 Stay Connected:
Have any questions, want feedback, or just want to discuss further contributions? Feel free to reach out directly to the maintainer on Discord: dot_notsam

Thank you again, and keep up the amazing work! 💻✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: [BUG] Dark/Light theme toggle does not switch application theme

2 participants