Workaround to enable MatAutocomplete to work inside EditForm#316
Closed
koskila wants to merge 1 commit into
Closed
Workaround to enable MatAutocomplete to work inside EditForm#316koskila wants to merge 1 commit into
koskila wants to merge 1 commit into
Conversation
|
i would appreciate this fix being merged to master because it's a blocker for my team |
Garth-Faigley
approved these changes
May 12, 2020
Garth-Faigley
left a comment
Garth-Faigley
left a comment
There was a problem hiding this comment.
This seriously needs to work in an EditForm.
Collaborator
|
Thanks for the PR. This is now resolved in the develop branch. #548 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables the usage of MatAutocomplete inside EditForms by creating a dummy value for ValueExpression. We needed to get this working for our project, so we implemented the workaround introduced on #213 (and #278).
Honestly - I think the solution Sebbstar introduced on PR #272 might be prettier in the long run, if it fixes the issue as well. However, we needed to get this working internally, and I thought it'd be foolish not to at least offer the solution up for grabs, just in case it would be useful for someone.
Cheers!