Add FX settlement invoice guard#583
Open
soave0529-oss wants to merge 2 commits into
Open
Conversation
Author
|
Scope clarification after checking prior same-issue work: this PR is intentionally narrower than the earlier FX settlement reconciliation submission (#225). It focuses on invoice-release rounding controls and credit-offset safety: supported currency minor units, invoice/account/settlement currency consistency, stale quote holds, processor settlement delta tolerance, credit approval evidence, and material variance blocking. It does not attempt provider fee caps, remittance reference deduplication, cross-border tax evidence, booking reconciliation, or broader settlement ledger reconciliation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #20
Adds a self-contained fx-settlement-invoice-guard package for Revenue Infrastructure.
This slice validates whether multi-currency invoices can be released or closed when invoice currency, account currency, settlement currency, FX snapshot freshness, minor-unit rounding, processor settlement amounts, credit-note offsets, and material variance approvals are consistent.
Why this is distinct:
Artifacts included:
Validation run locally:
Boundaries:
AI-assisted with OpenAI Codex; I reviewed the implementation and kept the module isolated.