Peer Instruction Migration to FastAPI#1209
Draft
sethbern wants to merge 3 commits intoRunestoneInteractive:mainfrom
Draft
Peer Instruction Migration to FastAPI#1209sethbern wants to merge 3 commits intoRunestoneInteractive:mainfrom
sethbern wants to merge 3 commits intoRunestoneInteractive:mainfrom
Conversation
Member
|
Thanks @sethbern . It looks like you found and cleaned up a number of things in my previous work on porting. The overall structure looks good so keep going I say. I'll take a closer look at the LTI stuff. I'm just back from two weeks of travel, so I've got a number of other things to take care of before I'm fully back at my desk. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @bnmnetp, I have done a first pass at moving peer instruction over to FastAPI. For now I am focusing on sync PI to get things working end-to-end before touching async.
Sync PI routes are in, Jinja2 templates ported from the old web2py views, and nav links fixed across
_base.html,menu.html, and the Sphinx book theme so everything points to/assignment/peer/.... Async stubs are there but not wired up yet. I've tested locally and seems to be working ok.A couple things I wanted your eyes on before I keep going: