396 convert regressors to num power#411
Open
apphp wants to merge 152 commits into
Open
Conversation
# Conflicts: # src/NeuralNet/Networks/FeedForward/FeedForward.php # tests/NeuralNet/Layers/Swish/SwishTest.php # tests/NeuralNet/Networks/NetworkTest.php
| * @author Andrew DalPino | ||
| * @author Samuel Akopyan <leumas.a@gmail.com> | ||
| */ | ||
| class KDNeighborsRegressor implements Estimator, Learner, Persistable |
Member
There was a problem hiding this comment.
It's been a while ... can you explain to me again why we need to create these namespaces?
| * @author Andrew DalPino | ||
| * @author Samuel Akopyan <leumas.a@gmail.com> | ||
| */ | ||
| class KNNRegressor implements Estimator, Learner, Online, Persistable |
Member
There was a problem hiding this comment.
Again, let's not power this model with NumPower yet.
| @@ -0,0 +1,232 @@ | |||
| <?php | |||
Member
There was a problem hiding this comment.
Revert back to no NumPower.
| @@ -0,0 +1,203 @@ | |||
| <?php | |||
Member
There was a problem hiding this comment.
This looks like it's just a copy of the original file just in a different namespace.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.