configure.ac: use pkg-config to retrieve openssl dependencies#426
configure.ac: use pkg-config to retrieve openssl dependencies#426ffontaine wants to merge 2 commits intoRsyncProject:masterfrom
Conversation
|
Do you have some comments on this PR? |
|
Thanks for your feedback. Patch has been applied in buildroot since February (https://git.buildroot.net/buildroot/commit/?id=e889a1c9e983753dd0fa5062d3b9475a8cba6072) and no build failures are raised by autobuilders since that time. It should be noted that |
|
@ffontaine it was fine after "make reconfigure". Note sure why autoconf didn't generate a good configure script for me yesterday. It's been many years since I worked with autoconf - about 20 years in fact, when I handed over to Wayne :-) |
|
@WayneD I'm happy with this |
Use pkg-config to retrieve openssl dependencies such as -latomic and avoids the following build failure when building statically on architectures such as sparc: /home/autobuild/autobuild/instance-1/output-1/host/lib/gcc/sparc-buildroot-linux-uclibc/10.4.0/../../../../sparc-buildroot-linux-uclibc/bin/ld: /home/autobuild/autobuild/instance-1/output-1/host/sparc-buildroot-linux-uclibc/sysroot/usr/lib/libcrypto.a(threads_pthread.o): in function `CRYPTO_atomic_add': threads_pthread.c:(.text+0x208): undefined reference to `__atomic_is_lock_free' Fixes: - http://autobuild.buildroot.org/results/49abbaa1eab94b248bff434b40728065d687e278 Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
tridge
left a comment
There was a problem hiding this comment.
I've added the rebuild in of configure as a commit on top of the PR, but failing CI tests. This will take more time to fix than I have time for right now, sorry. Please have a look and try to get CI passing. Test CI is passing in your own fork (you should really use a branch name other than master btw)
Use pkg-config to retrieve openssl dependencies such as
-latomicand avoids the following build failure when building statically on architectures such as sparc:Fixes:
Signed-off-by: Fabrice Fontaine fontaine.fabrice@gmail.com