Add Get Sensor IDs Method#35
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new authenticated /sensors endpoint to list known sensor IDs, along with documentation and a small helper script for retrieving them from the API.
Changes:
- Added
GET /sensorsroute in the server and documented the endpoint in the README. - Implemented
internal/sensorshandler that queries InfluxDB for tag values (host) and returns them as JSON. - Added Go tests for the new handler and a Python script to print sensor IDs from the CLI.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| scripts/list_sensors.py | CLI helper to call /sensors and print returned sensor IDs. |
| README.md | Documents the new GET /sensors endpoint, auth requirements, and response shape. |
| main.go | Wires the new /sensors handler behind auth + rate limiting. |
| internal/sensors/sensors.go | Implements the /sensors handler and Influx query/serialization logic. |
| internal/sensors/sensors_test.go | Adds unit tests for handler behavior and query/id collection helpers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #27