Rate Limit: Fix Memory Leak#32
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #25 by adding time-based eviction of per-API-key rate limiter entries so the in-memory key map doesn’t grow without bound over time.
Changes:
- Extend
ratelimit.Limiterto tracklastSeenper key and lazily evict idle keys after a configured TTL. - Update server wiring to configure the limiter with a 10-minute idle eviction TTL.
- Add tests for idle eviction behavior using an injected clock (no sleeps).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| main.go | Updates rate limiter construction to include an idle eviction TTL and adjusts the explanatory comment. |
| internal/ratelimit/ratelimit.go | Implements TTL-based lazy eviction with per-key lastSeen tracking and a sweep-on-access approach. |
| internal/ratelimit/ratelimit_test.go | Updates existing tests to use a long TTL helper and adds new tests covering eviction/retention semantics. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #25