Skip to content

RU-T50 build fix#250

Merged
ucswift merged 1 commit into
masterfrom
develop
Jun 19, 2026
Merged

RU-T50 build fix#250
ucswift merged 1 commit into
masterfrom
develop

Conversation

@ucswift

@ucswift ucswift commented Jun 19, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Bug Fixes
    • Fixed iOS build provisioning for Live Activity widget extensions to properly use automatic signing configuration aligned with the host app's development team credentials.

@coderabbitai

coderabbitai Bot commented Jun 19, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: af5d3814-3c1a-4c2c-b528-06f6f024e64f

📥 Commits

Reviewing files that changed from the base of the PR and between ed1af07 and 42af750.

📒 Files selected for processing (2)
  • app.config.ts
  • plugins/withCheckInLiveActivity.js

📝 Walkthrough

Walkthrough

app.config.ts adds a liveActivityExtension descriptor (target name and bundle ID) and registers it in the EAS iOS experimental appExtensions list. plugins/withCheckInLiveActivity.js removes the CODE_SIGNING_ALLOWED: 'NO' override from the widget extension and conditionally injects DEVELOPMENT_TEAM build settings plus DevelopmentTeam/ProvisioningStyle: Automatic Xcode target attributes when a host development team is available.

Changes

Live Activity Extension Signing & EAS Provisioning

Layer / File(s) Summary
EAS app config: Live Activity extension declaration
app.config.ts
Defines liveActivityExtension with target name and bundle ID derived from Env.BUNDLE_ID, and adds it to the EAS iOS experimental appExtensions array so the build provisions and embeds the extension profile.
Xcode plugin: automatic signing for widget target
plugins/withCheckInLiveActivity.js
Removes the explicit CODE_SIGNING_ALLOWED: 'NO' override and instead conditionally sets DEVELOPMENT_TEAM in build settings plus DevelopmentTeam and ProvisioningStyle: Automatic on the widget Xcode target when hostDevelopmentTeam is present.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • Resgrid/Unit#237: Directly modifies the same plugins/withCheckInLiveActivity.js to propagate host DEVELOPMENT_TEAM into the CheckInTimerWidget signing configuration — the same file and signing concern addressed here.
  • Resgrid/Unit#238: Overlaps on widget extension signing, team propagation, and entitlement handling in plugins/withCheckInLiveActivity.js, coordinated via app.config.ts.

Suggested reviewers

  • github-actions

Poem

🐇 Hop, hop, the widget can sign!
No more CODE_SIGNING_ALLOWED: 'NO' in line,
The team flows down from host to ext,
Provisioning style: Automatic — what's next?
EAS bundles the Live Activity tight,
A little rabbit cheers — the build feels right! 🎉

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'RU-T50 build fix' is vague and generic, referring to a ticket number without conveying the specific nature of the changes made to the codebase. Consider a more descriptive title that explains the actual changes, such as 'Configure Live Activity extension provisioning and signing' or 'Fix iOS Live Activity widget build configuration'.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ucswift

ucswift commented Jun 19, 2026

Copy link
Copy Markdown
Member Author

Approve

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is approved.

@ucswift ucswift merged commit 326d418 into master Jun 19, 2026
19 of 20 checks passed
@coderabbitai coderabbitai Bot mentioned this pull request Jun 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant