fix(devcontainer): bump docker-in-docker, introduce lockfile#498
Open
tristan-f-r wants to merge 1 commit into
Open
fix(devcontainer): bump docker-in-docker, introduce lockfile#498tristan-f-r wants to merge 1 commit into
tristan-f-r wants to merge 1 commit into
Conversation
[A PR was opened which fixed docker-in-docker for Ubuntu 26.04](devcontainers/features#1637), which was merged on May 12th and was a minor version bump for docker-in-docker version 2, but [this caused a regression on Ubuntu/**Debian** backends for hosts whose kernel does not load the `ip_tables` kernel module by default (e.g. RHEL-based distributions like Fedora)](devcontainers/features#1659). Our anaconda base image happens to be a Debian-based image, and I happen to be running on a host which does not load the `ip_tables` kernel module by default. We fix this by both: 1. Bumping docker-in-docker 2. Adding an associated lockfile which pins devcontainer features, while also pinning the base anaconda image version. _Reviewers: Make sure to test this in a devcontainer/codespace as well to make sure this works!_
Collaborator
|
How do you generate the This change makes sense. Merging it before or after the tutorial will depend on whether any of us can test it in time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A PR was opened which fixed docker-in-docker for Ubuntu 26.04, which was merged on May 12th and was a minor version bump for docker-in-docker version 2 (the version of docker-in-docker we use), but this caused a regression on Ubuntu/Debian backends for hosts whose kernel does not load the
ip_tableskernel module by default (e.g. RHEL-based distributions like Fedora). Our anaconda base image happens to be a Debian-based image, and I happen to be running on a host which does not load theip_tableskernel module by default.We fix this by both:
Reviewers: Make sure to test this in a devcontainer locally/in a codespace as well to make sure this works, though this issue shouldn't & doesn't seem to affect codespaces.