Skip to content

drivers: ethernet: add WCH CH390 SPI Ethernet driver#11593

Closed
HosakaSu wants to merge 3 commits into
RT-Thread:masterfrom
HosakaSu:ch390-eth-driver
Closed

drivers: ethernet: add WCH CH390 SPI Ethernet driver#11593
HosakaSu wants to merge 3 commits into
RT-Thread:masterfrom
HosakaSu:ch390-eth-driver

Conversation

@HosakaSu

@HosakaSu HosakaSu commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

拉取/合并请求描述：(PR description)

[

为什么提交这份PR (why to submit this PR)

This PR adds support for the WCH CH390 SPI Ethernet controller.

CH390 is a SPI Ethernet controller that can be used by RT-Thread BSPs to provide wired network connectivity. This PR adds the common CH390 SPI Ethernet driver and provides a
board-level port for the gd32407v-lckfb BSP.

你的解决方案是什么 (what is your solution)

  • Add CH390 SPI Ethernet driver under components/drivers/spi.
  • Add Kconfig and SConscript integration for RT_USING_CH390.
  • Register CH390 as an lwIP Ethernet device through eth_device.
  • Support CH390 hardware reset through GPIO when a reset pin is configured, and allow PIN_NONE when the reset pin is not connected.
  • Configure CH390 SPI as mode 3, MSB first.
  • Add gd32407v-lckfb BSP CH390 port with SPI0, CS, INT, reset pin, MAC address, and netif configuration.

Hardware verification was done with the following wiring:

  • PA3 -> INT
  • PA4 -> CS
  • PA5 -> SCK
  • PA6 -> SDO/MISO
  • PA7 -> SDI/MOSI
  • SPI mode: CPOL + CPHA

The CH390 netif was configured as 192.168.1.30/24, and the host PC IP was 192.168.1.100. Ping tests passed in both directions.

请提供验证的bsp和config (provide the config and bsp)

  • BSP:

bsp/gd32/arm/gd32407v-lckfb

  • .config:
CONFIG_BSP_USING_CH390=y
CONFIG_BSP_USING_SPI=y
CONFIG_BSP_USING_SPI0=y
CONFIG_RT_USING_CH390=y
CONFIG_RT_USING_LWIP=y
CONFIG_RT_USING_NETDEV=y
CONFIG_NETDEV_USING_IFCONFIG=y
CONFIG_NETDEV_USING_PING=y
CONFIG_NETDEV_USING_AUTO_DEFAULT=y
CONFIG_BSP_CH390_SPI_BUS_NAME="spi0"
CONFIG_BSP_CH390_SPI_DEVICE_NAME="spi10"
CONFIG_BSP_CH390_NETIF_NAME="e0"
CONFIG_BSP_CH390_CS_PIN=4
CONFIG_BSP_CH390_RST_PIN=-1
CONFIG_BSP_CH390_INT_PIN=3
CONFIG_BSP_CH390_SPI_MAX_HZ=5000000
CONFIG_BSP_CH390_POLL_INTERVAL_MS=20
CONFIG_RT_LWIP_IPADDR="192.168.1.30"
CONFIG_RT_LWIP_GWADDR="192.168.1.1"
CONFIG_RT_LWIP_MSKADDR="255.255.255.0"
# CONFIG_RT_LWIP_DHCP is not set
# CONFIG_BSP_CH390_USING_DHCP is not set

- action:

https://github.com/HosakaSu/rt-thread/actions/workflows/manual_dist.yml

]

<!-- 以下的内容不应该在提交PR时的message修改，修改下述message，PR会被直接关闭。请在提交PR后，浏览器查看PR并对以下检查项逐项check，没问题后逐条在页面上打钩。
The following content must not be changed in the submitted PR message. Otherwise, the PR will be closed immediately. After submitted PR, please use a web browser to visit PR, and check items one by one, and ticked them if no problem. -->

### 当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

- [ ] 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
- [ ] 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

### 代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

- [ ] 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
- [ ] 代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
- [ ] 没有垃圾代码，代码尽量精简，不包含`#if 0`代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
- [ ] 所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
- [ ] 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
- [ ] 代码是高质量的 Code in this PR is of high quality
- [ ] 已经使用[formatting](https://github.com/mysterywolf/formatting) 等源码格式化工具确保格式符合[RT-Thread代码规范](https://github.com/RT-Thread/rt-thread/blob/master/documentation/contribution_guide/coding_style_cn.md) This PR complies with [RT-Thread code specification](https://github.com/RT-Thread/rt-thread/blob/master/documentation/contribution_guide/coding_style_en.md)
- [ ] 如果是新增bsp, 已经添加ci检查到[.github/ALL_BSP_COMPILE.json](https://github.com/RT-Thread/rt-thread/blob/master/.github/ALL_BSP_COMPILE.json)  详细请参考链接[BSP自查](https://www.rt-thread.org/document/site/#/rt-thread-version/rt-thread-standard/development-guide/bsp-selfcheck/bsp_selfcheck)

@HosakaSu HosakaSu requested a review from kurisaW as a code owner July 8, 2026 15:38
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

👋 感谢您对 RT-Thread 的贡献！Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范，请在你的仓库中执行以下步骤运行代码格式化工作流（如果格式化CI运行失败）。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).

🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录（目录请以"/"结尾）
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to：ch390-eth-driver
  • 设置PR number为 \ Set the PR number to：11593
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后，提交将自动更新至 ch390-eth-driver 分支，关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the ch390-eth-driver branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们，再次感谢您的贡献！💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

📌 Code Review Assignment

🏷️ Tag: components

Reviewers: @Maihuanyi

Changed Files (Click to expand)
  • components/drivers/spi/Kconfig
  • components/drivers/spi/SConscript
  • components/drivers/spi/ch390.c
  • components/drivers/spi/ch390.h

🏷️ Tag: components_driver_spi

Reviewers: @Liang1795 @wdfk-prog

Changed Files (Click to expand)
  • components/drivers/spi/Kconfig
  • components/drivers/spi/SConscript
  • components/drivers/spi/ch390.c
  • components/drivers/spi/ch390.h

📊 Current Review Status (Last Updated: 2026-07-08 23:38 CST)

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

MemBrowse Memory Report

No memory changes detected for:

@CYFS3

CYFS3 commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

I think it would be better if the CH390 driver were available as a software package.

@kurisaW

kurisaW commented Jul 9, 2026

Copy link
Copy Markdown
Member

I think it would be better if the CH390 driver were available as a software package.

+1

@HosakaSu

HosakaSu commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

I think it would be better if the CH390 driver were available as a software package.

+1

thanks, I have moved the ch390 driver into a standalone package repository and submit the package index to RT-Thread/packages, and this PR will be closed

@HosakaSu HosakaSu closed this Jul 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kurisaW kurisaW Awaiting requested review from kurisaW kurisaW is a code owner

Assignees

No one assigned

Labels

BSP: GD32 BSP related with GD32 BSP component: drivers/spi component: drivers Component

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@HosakaSu @CYFS3 @kurisaW