Skip to content

drivers: pic: fix PIRQ lookup upper bound#11573

Open
Old-Ding wants to merge 1 commit into
RT-Thread:masterfrom
Old-Ding:codex/pic-find-pirq-upper-bound
Open

drivers: pic: fix PIRQ lookup upper bound#11573
Old-Ding wants to merge 1 commit into
RT-Thread:masterfrom
Old-Ding:codex/pic-find-pirq-upper-bound

Conversation

@Old-Ding

@Old-Ding Old-Ding commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

What this PR does

Fixes the upper-bound check in rt_pic_find_pirq().

rt_pic_linear_irq() stores irq_nr as a count and sets pic->pirqs to the first entry in that range. The valid IRQ range is therefore [irq_start, irq_start + irq_nr). The current inclusive check can return pic->pirqs[irq_nr] when irq == irq_start + irq_nr, which is one entry past the range.

Verification

  • git diff --check
  • git show --stat --check --format=fuller HEAD
  • git ls-files --eol -- components/drivers/pic/pic.c

I could not run an RT-Thread build locally because this Windows environment does not have scons, gcc, or arm-none-eabi-gcc installed.

Generated-by: OpenAI Codex

@Old-Ding
drivers: pic: Fix PIRQ lookup upper bound
ce03012 
rt_pic_linear_irq() stores irq_nr as a count and assigns pic->pirqs to the first entry in that range. rt_pic_find_pirq() therefore must treat the upper bound as exclusive.

The inclusive check could return pic->pirqs[irq_nr] when irq equals irq_start + irq_nr, which is one entry past the allocated range.

Generated-by: OpenAI Codex
Signed-off-by: Old-Ding <35417409+Old-Ding@users.noreply.github.com>
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown

👋 感谢您对 RT-Thread 的贡献！Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范，请在你的仓库中执行以下步骤运行代码格式化工作流（如果格式化CI运行失败）。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).

🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录（目录请以"/"结尾）
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to：codex/pic-find-pirq-upper-bound
  • 设置PR number为 \ Set the PR number to：11573
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后，提交将自动更新至 codex/pic-find-pirq-upper-bound 分支，关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the codex/pic-find-pirq-upper-bound branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们，再次感谢您的贡献！💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown

📌 Code Review Assignment

🏷️ Tag: components

Reviewers: @Maihuanyi

Changed Files (Click to expand)
  • components/drivers/pic/pic.c

📊 Current Review Status (Last Updated: 2026-07-06 11:08 CST)

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown

MemBrowse Memory Report

No memory changes detected for:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

component: drivers/pic component: drivers Component

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Old-Ding