bsp: rockchip: fix CAN-FD bit timing copy size#11571
Open
Old-Ding wants to merge 1 commit into
Open
Conversation
RT_CAN_CMD_SET_BITTIMING receives an array of struct rt_can_bit_timing entries. The Rockchip CAN-FD driver used sizeof(&timing->items[n]) when copying those entries, so only pointer-sized bytes were copied into the device configuration. Use the element size so both arbitration and data phase timing structures are copied completely. Generated-by: OpenAI Codex Signed-off-by: Old-Ding <35417409+Old-Ding@users.noreply.github.com>
|
👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread! 为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。 🛠 操作步骤 | Steps
完成后,提交将自动更新至 如有问题欢迎联系我们,再次感谢您的贡献!💐 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Fixes the Rockchip CAN-FD
RT_CAN_CMD_SET_BITTIMINGhandler to copy the fullstruct rt_can_bit_timingentries fromtiming->items.The current code uses
sizeof(&timing->items[n]), which is the size of a pointer, when copying intocan->config.can_timingandcan->config.canfd_timing. That can leave part of each timing structure unchanged. Other CAN drivers copy the fullitems[n]entry.Verification
git diff --checkgit show --stat --check --format=fuller HEADgit ls-files --eol -- bsp/rockchip/dm/can/canfd-rockchip.crg -n sizeof\s*\(&timing->items bsp/rockchip/dm/can/canfd-rockchip.creturns no matchesI could not run an RT-Thread build locally because this Windows environment does not have
scons,gcc, orarm-none-eabi-gccinstalled.Generated-by: OpenAI Codex