Skip to content

bsp: rockchip: fix CAN-FD bit timing copy size#11571

Open
Old-Ding wants to merge 1 commit into
RT-Thread:masterfrom
Old-Ding:codex/rockchip-canfd-bittiming-size
Open

bsp: rockchip: fix CAN-FD bit timing copy size#11571
Old-Ding wants to merge 1 commit into
RT-Thread:masterfrom
Old-Ding:codex/rockchip-canfd-bittiming-size

Conversation

@Old-Ding

@Old-Ding Old-Ding commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

What this PR does

Fixes the Rockchip CAN-FD RT_CAN_CMD_SET_BITTIMING handler to copy the full struct rt_can_bit_timing entries from timing->items.

The current code uses sizeof(&timing->items[n]), which is the size of a pointer, when copying into can->config.can_timing and can->config.canfd_timing. That can leave part of each timing structure unchanged. Other CAN drivers copy the full items[n] entry.

Verification

  • git diff --check
  • git show --stat --check --format=fuller HEAD
  • git ls-files --eol -- bsp/rockchip/dm/can/canfd-rockchip.c
  • rg -n sizeof\s*\(&timing->items bsp/rockchip/dm/can/canfd-rockchip.c returns no matches

I could not run an RT-Thread build locally because this Windows environment does not have scons, gcc, or arm-none-eabi-gcc installed.

Generated-by: OpenAI Codex

RT_CAN_CMD_SET_BITTIMING receives an array of struct rt_can_bit_timing entries. The Rockchip CAN-FD driver used sizeof(&timing->items[n]) when copying those entries, so only pointer-sized bytes were copied into the device configuration.

Use the element size so both arbitration and data phase timing structures are copied completely.

Generated-by: OpenAI Codex
Signed-off-by: Old-Ding <35417409+Old-Ding@users.noreply.github.com>
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown

👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).


🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录(目录请以"/"结尾)
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to:codex/rockchip-canfd-bittiming-size
  • 设置PR number为 \ Set the PR number to:11571
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后,提交将自动更新至 codex/rockchip-canfd-bittiming-size 分支,关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the codex/rockchip-canfd-bittiming-size branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们,再次感谢您的贡献!💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@github-actions github-actions Bot added BSP BSP: Rockchip BSP related with Rockchip labels Jul 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BSP: Rockchip BSP related with Rockchip BSP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant