Skip to content

bsp: renesas: Fix RA pin name digit checks#11568

Merged
Rbb666 merged 1 commit into
RT-Thread:masterfrom
Old-Ding:codex/renesas-pin-name-digit-check
Jul 6, 2026
Merged

bsp: renesas: Fix RA pin name digit checks#11568
Rbb666 merged 1 commit into
RT-Thread:masterfrom
Old-Ding:codex/renesas-pin-name-digit-check

Conversation

@Old-Ding

@Old-Ding Old-Ding commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Summary

  • validate the second and third digits in RA \PXXX\ pin names against
    ame[2]\ and
    ame[3]\
  • stop non-digit suffix characters from passing only because
    ame[1]\ is a digit

Testing

  • git diff --check -- bsp/renesas/libraries/HAL_Drivers/drivers/drv_gpio.c
  • git show --stat --check --format=fuller HEAD

@Old-Ding
bsp: renesas: Fix RA pin name digit checks
4ed4aff 
Validate the second and third digits of RA PXXX pin names against their own characters. The previous checks used name[1] for those upper bounds, so non-digit suffixes could pass validation.

Generated-by: OpenAI Codex
Signed-off-by: Old-Ding <35417409+Old-Ding@users.noreply.github.com>
@Old-Ding Old-Ding requested review from Rbb666 and kurisaW as code owners July 6, 2026 01:44
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown

👋 感谢您对 RT-Thread 的贡献！Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范，请在你的仓库中执行以下步骤运行代码格式化工作流（如果格式化CI运行失败）。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).

🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录（目录请以"/"结尾）
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to：codex/renesas-pin-name-digit-check
  • 设置PR number为 \ Set the PR number to：11568
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后，提交将自动更新至 codex/renesas-pin-name-digit-check 分支，关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the codex/renesas-pin-name-digit-check branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们，再次感谢您的贡献！💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@github-actions github-actions Bot added BSP BSP: Renesas BSP related with Renesas labels Jul 6, 2026
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown

📌 Code Review Assignment

🏷️ Tag: bsp_renesas

Reviewers: @kurisaW

Changed Files (Click to expand)
  • bsp/renesas/libraries/HAL_Drivers/drivers/drv_gpio.c

📊 Current Review Status (Last Updated: 2026-07-06 09:45 CST)

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown

MemBrowse Memory Report

No memory changes detected for:

@Rbb666

Rbb666 commented Jul 6, 2026

Copy link
Copy Markdown
Member

大佬，有联系方式吗？加个vx呀

@Rbb666 Rbb666 merged commit 31e6343 into RT-Thread:master Jul 6, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Rbb666 Rbb666 Rbb666 approved these changes
@kurisaW kurisaW Awaiting requested review from kurisaW kurisaW is a code owner

Assignees

No one assigned

Labels

BSP: Renesas BSP related with Renesas BSP

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Old-Ding @Rbb666