Skip to content

components: cherryusb: Fix USB host bounds checks#11566

Open
Old-Ding wants to merge 1 commit into
RT-Thread:masterfrom
Old-Ding:codex/usbh-config-desc-bounds
Open

components: cherryusb: Fix USB host bounds checks#11566
Old-Ding wants to merge 1 commit into
RT-Thread:masterfrom
Old-Ding:codex/usbh-config-desc-bounds

Conversation

@Old-Ding

@Old-Ding Old-Ding commented Jul 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • validate USB host config descriptor headers before reading bDescriptorType
  • reject interface and endpoint descriptors shorter than their fixed layouts
  • reject truncated descriptor lists instead of accepting a partial parse
  • keep recursive hubport lookup results separate from the current loop port so a miss does not replace the loop state with NULL

Testing

  • git diff origin/master..HEAD --check
  • git show --stat --check --format=fuller HEAD

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown

👋 感谢您对 RT-Thread 的贡献！Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范，请在你的仓库中执行以下步骤运行代码格式化工作流（如果格式化CI运行失败）。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).

🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录（目录请以"/"结尾）
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to：codex/usbh-config-desc-bounds
  • 设置PR number为 \ Set the PR number to：11566
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后，提交将自动更新至 codex/usbh-config-desc-bounds 分支，关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the codex/usbh-config-desc-bounds branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们，再次感谢您的贡献！💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@github-actions

github-actions Bot commented Jul 6, 2026 •
edited
Loading

Copy link
Copy Markdown

📌 Code Review Assignment

🏷️ Tag: components

Reviewers: @Maihuanyi

Changed Files (Click to expand)
  • components/drivers/usb/cherryusb/core/usbh_core.c

📊 Current Review Status (Last Updated: 2026-07-06 09:35 CST)

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@Old-Ding
components: cherryusb: Fix USB host bounds checks
f3cdfec 
Validate descriptor headers and per-type lengths before reading the current USB host config descriptor entry. Reject truncated descriptor lists instead of silently accepting a partial parse.

Keep recursive hubport lookup results separate from the current loop port so a recursive miss does not replace the loop state with NULL.

Generated-by: OpenAI Codex
Signed-off-by: Old-Ding <35417409+Old-Ding@users.noreply.github.com>
@Old-Ding Old-Ding force-pushed the codex/usbh-config-desc-bounds branch from c3de539 to f3cdfec Compare July 6, 2026 01:34
@Old-Ding Old-Ding changed the title components: cherryusb: Bound config descriptor parsing components: cherryusb: Fix USB host bounds checks Jul 6, 2026
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown

MemBrowse Memory Report

No memory changes detected for:

@Maihuanyi

Maihuanyi commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

component: drivers/usb component: drivers Component

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Old-Ding @Maihuanyi