Skip to content

bsp: nxp: Bound VGLite buffer reader access#11565

Open
Old-Ding wants to merge 1 commit into
RT-Thread:masterfrom
Old-Ding:codex/vglite-bufferred-fgets-bounds
Open

bsp: nxp: Bound VGLite buffer reader access#11565
Old-Ding wants to merge 1 commit into
RT-Thread:masterfrom
Old-Ding:codex/vglite-bufferred-fgets-bounds

Conversation

@Old-Ding

@Old-Ding Old-Ding commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Summary\n- check the requested read limit before reading ptr[i] in bufferred_fgets()\n- guard CR/LF skipping with the available input byte count so full-buffer reads do not inspect past fd->data_buf\n\n## Verification\n- git diff --check HEAD^ HEAD -- bsp/nxp/imx/imxrt/libraries/drivers/vglite/font/buf_reader.c\n- git show --stat --check --format=fuller HEAD\n- git ls-files --eol -- bsp/nxp/imx/imxrt/libraries/drivers/vglite/font/buf_reader.c

Check the buffer limits before reading ptr[i] in bufferred_fgets(). Also guard CR/LF skipping against the available input bytes so reading a full buffer does not inspect one byte past the source.

Generated-by: OpenAI Codex
Signed-off-by: Old-Ding <35417409+Old-Ding@users.noreply.github.com>
@Old-Ding Old-Ding requested a review from Rbb666 as a code owner July 6, 2026 01:16
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown

👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).


🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录(目录请以"/"结尾)
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to:codex/vglite-bufferred-fgets-bounds
  • 设置PR number为 \ Set the PR number to:11565
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后,提交将自动更新至 codex/vglite-bufferred-fgets-bounds 分支,关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the codex/vglite-bufferred-fgets-bounds branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们,再次感谢您的贡献!💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@github-actions github-actions Bot added BSP: NXP Code related with NXP BSP labels Jul 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BSP: NXP Code related with NXP BSP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant