Skip to content

[bsp][drivers][soft_i2c] unify the software I2C driver#11404

Merged
Rbb666 merged 1 commit into
RT-Thread:masterfrom
CYFS3:soft_i2c
Jul 16, 2026
Merged

[bsp][drivers][soft_i2c] unify the software I2C driver#11404
Rbb666 merged 1 commit into
RT-Thread:masterfrom
CYFS3:soft_i2c

Conversation

@CYFS3

@CYFS3 CYFS3 commented May 19, 2026

Copy link
Copy Markdown
Contributor

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

仓库中多个 BSP 各自维护软件 I2C 驱动,存在重复实现、配置入口不一致、板级默认引脚丢失风险以及软件总线名称不统一的问题。本 PR 统一使用组件层软件 I2C 实现,并保留原 BSP 的使用方式和引脚信息。

你的解决方案是什么 (what is your solution)

  • 删除 BSP 中重复的软件 I2C 驱动及构建入口,统一使用 components/drivers/i2c
  • 软件总线名称统一为 swi2c0swi2c8,相关设备提示同步标注 swi2cX
  • 原本具有软件 I2C 配置的 BSP 在 On-chip Peripheral Drivers 中保留唯一板级入口;没有板级入口的 BSP 继续从组件菜单配置。
  • 板级菜单使用通用 RT_SOFT_I2Cx_SCL_PINRT_SOFT_I2Cx_SDA_PIN,保留原引脚默认值并允许用户修改。
  • 板载传感器等消费者选择 BSP_USING_SOFT_I2Cx,使板级菜单和组件菜单状态同步。
  • 清理重复菜单定义,并保持分支相对最新 master 为单个提交。

请提供验证的bsp和config (provide the config and bsp)

  • BSP:

    • bsp/stm32/stm32f407-rt-spark
    • bsp/stm32/stm32f407-atk-explorer
    • bsp/renesas/ra6m3-hmi-board
    • bsp/apm32/apm32e103ze-evalboard
    • bsp/synwit/swm341-mini
  • .config:

    • CONFIG_RT_USING_I2C=y
    • CONFIG_RT_USING_SOFT_I2C=y
    • CONFIG_RT_USING_SOFT_I2Cx=y
    • CONFIG_RT_SOFT_I2Cx_SCL_PIN=
    • CONFIG_RT_SOFT_I2Cx_SDA_PIN=
  • 验证结果:

    • git diff rtt/master..HEAD --check 通过。
    • 156 个 BSP 通过完整 Kconfig 语义检查,4 个模板通过片段语法检查。
    • 161 个板级默认配置的引脚值与组件配置一致,并可被用户覆盖。
    • 星火一号启用 BSP_USING_AHT21 后,板级 swi2c3 与组件层配置同时启用,默认 SCL/SDA 为 64/65。
    • 159 个标准板级入口均无重复定义;STM32L1 模板仍存在与本 PR 无关的既有 BSP_USING_USBD 依赖环。
    • 尚未进行完整硬件实机验证。
  • action:

    • 推送后等待 PR CI 结果。

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用clang-format 源码格式化工具确保格式符合RT-Thread代码规范 This PR has been formatted with clang-format and complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

@github-actions

Copy link
Copy Markdown

👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).


🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录(目录请以"/"结尾)
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to:soft_i2c
  • 设置PR number为 \ Set the PR number to:11404
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后,提交将自动更新至 soft_i2c 分支,关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the soft_i2c branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们,再次感谢您的贡献!💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@github-actions github-actions Bot added BSP: NXP Code related with NXP BSP: STM32 BSP related with ST/STM32 BSP BSP: Renesas BSP related with Renesas BSP: GD32 BSP related with GD32 BSP: Infineon BSP related with Infineon BSP: Cvitek BSP related with cvitek BSP: AT32 BSP related with AT32 BSP: WCH BSP related with WCH labels May 19, 2026
@CYFS3
CYFS3 force-pushed the soft_i2c branch 2 times, most recently from 4556e4f to 317dcd0 Compare May 19, 2026 12:41
@CYFS3

CYFS3 commented May 19, 2026

Copy link
Copy Markdown
Contributor Author
image 这个栈溢出了,stm32的ci报错跟此pr无关

@CYFS3 CYFS3 closed this May 22, 2026
@CYFS3 CYFS3 reopened this May 22, 2026
@CYFS3
CYFS3 marked this pull request as draft May 22, 2026 01:31
@github-actions github-actions Bot added BSP: Loongson BSP related with Loongson BSP: HC32 BSP related with HC32 BSP: ESP32 BSP related with ESP labels Jul 15, 2026
@CYFS3 CYFS3 changed the title [bsp][drivers][soft_i2c]:merge the software i2c driver [bsp][drivers][soft_i2c] unify the software I2C driver Jul 15, 2026
@CYFS3
CYFS3 marked this pull request as ready for review July 15, 2026 10:06
@github-actions

github-actions Bot commented Jul 15, 2026

Copy link
Copy Markdown

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

@CYFS3 CYFS3 closed this Jul 16, 2026
@CYFS3 CYFS3 reopened this Jul 16, 2026
@Rbb666
Rbb666 merged commit 414ff7f into RT-Thread:master Jul 16, 2026
106 checks passed
@CYFS3
CYFS3 deleted the soft_i2c branch July 17, 2026 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BSP: AT32 BSP related with AT32 BSP: Cvitek BSP related with cvitek BSP: ESP32 BSP related with ESP BSP: GD32 BSP related with GD32 BSP: HC32 BSP related with HC32 BSP: Infineon BSP related with Infineon BSP: Loongson BSP related with Loongson BSP: NXP Code related with NXP BSP: Renesas BSP related with Renesas BSP: STM32 BSP related with ST/STM32 BSP: WCH BSP related with WCH BSP component: drivers/i2c component: drivers Component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants