[ci] Run build pipeline on candidate without publishing artifacts/packages#313
Merged
Merged
Conversation
Add candidate to PR triggers so pushes and PRs against candidate run the full build pipeline. Gate all S3 upload steps on ref_name and base_ref not being 'candidate' so no packages are published until candidate is promoted to develop/mainline. Co-authored-by: Claude <claude@anthropic.com>
Candidate builds are validation-only; no artifacts should be retained. The verify steps (dpkg-deb, rpm -qip) still confirm packages were built. Co-authored-by: Claude <claude@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates CI workflows so the candidate branch runs the full build/scan pipeline (push + PR), while attempting to prevent publishing (artifacts/S3 uploads) from candidate builds.
Changes:
- Add
candidateto CodeQL push + PR triggers. - Add
candidateto build-relocatable-packages workflow PR triggers and reorder push triggers to include it. - Gate artifact upload and S3 upload steps to avoid publishing when the run is associated with
candidate.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
.github/workflows/codeql.yml |
Adds candidate to branch triggers so CodeQL runs on pushes/PRs involving candidate. |
.github/workflows/build-relocatable-packages.yml |
Runs packaging CI for candidate PRs and gates artifact/S3 publishing based on branch context. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Gate the release-summary build-report artifact upload behind the same candidate condition as the package artifacts. Also drop "(always, for inspection)" from the artifact upload step names — they are no longer unconditional. Co-authored-by: Claude <claude@anthropic.com>
gilbertlee-amd
approved these changes
May 23, 2026
thananon
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Add
candidateto PR triggers so pushes and PRs run the full build pipeline. Gate all artifact and S3 upload steps so no artifacts/packages are published untilcandidateis promoted todevelop.Technical Details
candidatetopull_requestbranch triggers so PRs against it run the full build pipelinecandidate; artifacts and packages are never published.candidatetodevelopwill trigger build + artifact/package upload.Test Plan
Test Result
Submission Checklist