Render unified CI-signal metadata in the PR comment (analyzer#141)#142
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Query Doctor Analysis
3 queries analyzed
2 pre-existing issues
SELECT "guests"."id", "guests"."session_id", "guests"."username", "guests"."avatar_path", "guests"."color", "guests"."side", "guests"."audio_recording_path", "guests"."audio_recording_public", "gue...
indexassets(event_id, inserted_at desc)
cost 31,003,449 → 1,498 (100% reduction)SELECT * FROM guest_ip_addresses WHERE ip_address = '127.0.0.1';
indexguest_ip_addresses(ip_address)
cost 154,402 → 8 (100% reduction)
Using assumed statistics (10000000 rows/table). For better results, sync production stats.
Consume the metadata now returned by POST /ci/runs so the GitHub PR
comment speaks the same language as the Slack/webhook alert (analyzer#141).
- postToSiteApi returns { id, url, metadata } instead of just the run id
- the run link and per-query links come straight from the API response
(url + metadata.queries), replacing the self-derived /ixr/ci route
- the comment renders the roll-up line and get_ci_run footer verbatim,
plus a small docs link, all sourced from the metadata payload
- everything degrades for an unlinked repo (no url, empty queries)
- golden tests cover the linked, unlinked, no-metadata, and null-docsUrl cases
Per-signal icons are wired through (runMetadata.signalKeys) but not
rendered yet — the image assets don't exist. Tracked in Site #3070.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
veksen
force-pushed
the
veksen/analyzer-141
branch
from
8579aa4 to
73f6962
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GitHub PR comment now consumes the
metadatapayload thatPOST /ci/runsreturns, so it speaks the same language as the Slack/webhook alert:postToSiteApireturns{ id, url, metadata }, and the run link plus per-query links come straight from the API response (url+metadata.queries) instead of the self-derived/ixr/ci/route. The comment renders the roll-up line andget_ci_runfooter verbatim alongside a smalldocslink, and degrades cleanly for an unlinked repo (nourl, emptyqueries). Golden/snapshot tests cover the linked, unlinked, no-metadata, and null-docsUrlcases. Per-signal icons are wired through (runMetadata.signalKeys) but intentionally not rendered yet — the image assets don't exist, tracked in Site #3070.🤖 Generated with Claude Code