Skip to content

feat: use display name to fix duplicate code mappings#870

Open
Lash-L wants to merge 1 commit into
mainfrom
duplicate_code_mappings
Open

feat: use display name to fix duplicate code mappings#870
Lash-L wants to merge 1 commit into
mainfrom
duplicate_code_mappings

Conversation

@Lash-L

@Lash-L Lash-L commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

This fixes a large portion of our enums that are duplicates. This will be a breaking change on HA, but should likely be okay

@Lash-L Lash-L requested review from allenporter and Copilot July 8, 2026 02:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@codecov

codecov Bot commented Jul 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.56627% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
roborock/data/v1/v1_containers.py 50.00% 5 Missing ⚠️
roborock/data/code_mappings.py 87.50% 1 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ
roborock/data/dyad/dyad_code_mappings.py 100.00% <100.00%> (ø)
roborock/data/v1/v1_code_mappings.py 100.00% <100.00%> (ø)
tests/data/test_code_mappings.py 100.00% <100.00%> (ø)
tests/data/v1/test_v1_containers.py 100.00% <100.00%> (ø)
roborock/data/code_mappings.py 90.36% <87.50%> (-0.43%) ⬇️
roborock/data/v1/v1_containers.py 88.26% <50.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants