Skip to content

fix: enable Qrevo Master wash/fill dock features (code 14 dock, Roborock QRevo S5A) #866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Jason-Morcos wants to merge 1 commit into from
+8 −1
Closed

fix: enable Qrevo Master wash/fill dock features (code 14 dock, Roborock QRevo S5A) #866

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions roborock/device_features.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -650,6 +650,7 @@ def get_supported_features(self) -> list[str]:
RoborockDockTypeCode.p10_dock,
RoborockDockTypeCode.p10_pro_dock,
RoborockDockTypeCode.s8_maxv_ultra_dock,
RoborockDockTypeCode.qrevo_master_dock,
RoborockDockTypeCode.qrevo_s_dock,
RoborockDockTypeCode.saros_r10_dock,
RoborockDockTypeCode.qrevo_curv_dock,
Expand Down
8 changes: 7 additions & 1 deletion tests/devices/traits/v1/test_device_features.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,9 @@
import pytest
from syrupy import SnapshotAssertion

from roborock.data import HomeDataDevice
from roborock.data import HomeDataDevice, RoborockDockTypeCode
from roborock.data.v1.v1_containers import ConsumableField, StatusField
from roborock.device_features import is_wash_n_fill_dock
from roborock.devices.device import RoborockDevice
from roborock.devices.traits.v1.consumeable import ConsumableTrait
from roborock.devices.traits.v1.status import StatusTrait
Expand All @@ -15,6 +16,11 @@
}


def test_qrevo_master_dock_is_wash_n_fill_dock() -> None:
"""Test that the Qrevo Master dock supports wash and fill features."""
assert is_wash_n_fill_dock(RoborockDockTypeCode.qrevo_master_dock)


@pytest.mark.parametrize(
("device_info"),
V1_DEVICES.values(),
Expand Down