Skip to content

fix: disable DoT during VPN connection #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mufeedali wants to merge 1 commit into
base: stable
Choose a base branch
from
+39 −0
Open

fix: disable DoT during VPN connection #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions proton/vpn/backend/networkmanager/protocol/openvpn/openvpn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,7 @@ def _modify_connection(self, private_key_passphrase):
"""
self._set_custom_connection_id()
self._set_connection_user_owned()
self._disable_dns_over_tls()
self._set_server_certificate_check()
self._set_dns()
self._set_vpn_cert_credentials(private_key_passphrase)
Expand All @@ -258,6 +259,18 @@ def _set_connection_user_owned(self):
None
)

def _disable_dns_over_tls(self):
"""Disable DNS-over-TLS for this connection.

Overrides the global systemd-resolved DNSOverTLS setting so that
ProtonVPN's internal DNS server (plain DNS, port 53) is reachable
even when the system is configured with DNSOverTLS=yes.
"""
self._connection_settings.set_property(
NM.SETTING_CONNECTION_DNS_OVER_TLS,
NM.SettingConnectionDnsOverTls.NO
)

def _set_server_certificate_check(self):
appened_domain = "name:" + self._vpnserver.domain
self._vpn_settings.add_data_item(
Expand Down
13 changes: 13 additions & 0 deletions proton/vpn/backend/networkmanager/protocol/protun/protun.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ def _modify_connection(self):
self._set_interface_name()
self._set_connection_type()
self._set_connection_user_owned()
self._disable_dns_over_tls()
self.connection.add_setting(self._connection_settings)

self._set_route()
Expand Down Expand Up @@ -121,6 +122,18 @@ def _set_connection_user_owned(self):
None
)

def _disable_dns_over_tls(self):
"""Disable DNS-over-TLS for this connection.

Overrides the global systemd-resolved DNSOverTLS setting so that
ProtonVPN's internal DNS server (plain DNS, port 53) is reachable
even when the system is configured with DNSOverTLS=yes.
"""
self._connection_settings.set_property(
NM.SETTING_CONNECTION_DNS_OVER_TLS,
NM.SettingConnectionDnsOverTls.NO
)

def _set_route(self):
ipv4_config = NM.SettingIP4Config.new()
ipv6_config = NM.SettingIP6Config.new()
Expand Down
13 changes: 13 additions & 0 deletions proton/vpn/backend/networkmanager/protocol/wireguard/wireguard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,7 @@ def _modify_connection(self):
self._set_interface_name()
self._set_connection_type()
self._set_connection_user_owned()
self._disable_dns_over_tls()
self.connection.add_setting(self._connection_settings)

self._set_route()
Expand Down Expand Up @@ -209,6 +210,18 @@ def _set_connection_user_owned(self):
None
)

def _disable_dns_over_tls(self):
"""Disable DNS-over-TLS for this connection.

Overrides the global systemd-resolved DNSOverTLS setting so that
ProtonVPN's internal DNS server (plain DNS, port 53) is reachable
even when the system is configured with DNSOverTLS=yes.
"""
self._connection_settings.set_property(
NM.SETTING_CONNECTION_DNS_OVER_TLS,
NM.SettingConnectionDnsOverTls.NO
)

def _set_route(self):
ipv4_config = NM.SettingIP4Config.new()
ipv6_config = NM.SettingIP6Config.new()
Expand Down