enh(engines/utils): use tuple/dict comprehensions in PrepareBatchExtraInput

[Zeesejo]

Fixes #8806

Description

This implements the suggestion made by @ericspod in the review of #8747.

In PrepareBatchExtraInput.__call__ (monai/engines/utils.py), replace the imperative list.append loop and dict.update loop with a direct tuple generator expression and dict comprehension, respectively. Also adds explicit type annotations (args_: tuple and kwargs_: dict) for clarity.

Before:

args_ = []
kwargs_ = {}
...
if isinstance(self.extra_keys, (str, list, tuple)):
    for k in ensure_tuple(self.extra_keys):
        args_.append(_get_data(k))
elif isinstance(self.extra_keys, dict):
    for k, v in self.extra_keys.items():
        kwargs_.update({k: _get_data(v)})
return ..., tuple(args_), kwargs_

After:

args_: tuple = ()
kwargs_: dict = {}
...
if isinstance(self.extra_keys, (str, list, tuple)):
    args_ = tuple(_get_data(k) for k in ensure_tuple(self.extra_keys))
elif isinstance(self.extra_keys, dict):
    kwargs_ = {k: _get_data(v) for k, v in self.extra_keys.items()}
return ..., args_, kwargs_

Types of changes

• Non-breaking change (fix or new feature that would not break existing functionality).
• Breaking change (fix or new feature that would cause existing functionality to change).
• New tests added to cover the changes.
• Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
• Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
• In-line docstrings updated.
• Documentation updated, tested make html command in the docs/ folder.

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 2ffe0a84-9cdd-49d8-8bdc-8810a7d98ad2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}