Skip to content

Bump vscode-languageclient to 10 (LSP 3.18)#5534

Draft
Copilot wants to merge 2 commits into
mainfrom
copilot/bump-vscode-languageserver-to-10
Draft

Bump vscode-languageclient to 10 (LSP 3.18)#5534
Copilot wants to merge 2 commits into
mainfrom
copilot/bump-vscode-languageserver-to-10

Conversation

Copilot AI commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Upgrades the LSP client to v10 / protocol 3.18 and addresses the two breaking changes that affect this extension.

Dependencies

  • vscode-languageclient ^9.0.1^10.0.0, vscode-languageserver-protocol ^3.17.5^3.18.0 (transitively pulls vscode-jsonrpc@9, vscode-languageserver-types@3.18, vscode-languageserver-textdocument@1.0.13). Lockfile keeps the existing sha1 integrity convention.

Type fixes for stricter v10 typings

These are caught only by tsc --noEmit (esbuild build and tests don't type-check); no runtime behavior change.

  • ExtensionCommands.tssendRequest/onRequest now use NoInfer<RequestParam<P>>, exposing that getEditorContext() already returns IEditorContext | undefined. The request types now reflect this:

    export interface IInvokeExtensionCommandRequestArguments {
        name: string;
        context: IEditorContext | undefined; // was IEditorContext
    }
    
    export const GetEditorContextRequestType = new RequestType<
        IGetEditorContextRequestArguments,
        IEditorContext | undefined, // was IEditorContext
        void
    >("editor/getEditorContext");
  • session.ts — 3.18's DocumentSelector (pattern is now a GlobPattern including RelativePattern) is no longer structurally assignable to VS Code's. Cast at the single UI call site, since our selector only uses language/scheme:

    vscode.languages.createLanguageStatusItem(
        "powershell",
        this.documentSelector as vscode.DocumentSelector,
    );

Verified unaffected

The other v10 breaking changes don't apply: the LogOutputChannel requirement is already met by LanguageClientOutputChannelAdapter; the showDocument middleware CancellationToken, browser-client param reorder, and documentColor/colorPresentation null removal touch code paths we don't use.

Note: v10 requires VS Code ^1.91.0, satisfied by the current engines.vscode of ^1.114.0.

Copilot AI changed the title [WIP] Bump vscode languageserver to 10 and verify no breaking changes Bump vscode-languageclient to 10 (LSP 3.18) Jun 18, 2026
Copilot AI requested a review from andyleejordan June 18, 2026 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants