Skip to content

chore: update PHP CI workflow#162

Merged
marandaneto merged 2 commits into
mainfrom
chore/update-php-ci-workflow
Jun 12, 2026
Merged

chore: update PHP CI workflow#162
marandaneto merged 2 commits into
mainfrom
chore/update-php-ci-workflow

Conversation

@marandaneto

@marandaneto marandaneto commented Jun 11, 2026

Copy link
Copy Markdown
Member

💡 Motivation and Context

Keep the PHP CI workflow aligned with project metadata changes, reduce wasted CI work, and separate regular test runs from coverage collection.

💚 How did you test it?

  • composer validate --no-check-lock --no-check-version --strict

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

If releasing new changes

  • Ran pnpm changeset to generate a changeset file

@greptile-apps

greptile-apps Bot commented Jun 11, 2026

Copy link
Copy Markdown
Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
.github/workflows/php.yml:64-80
**Coverage runs even when tests fail**

The `coverage` job has no `needs: phpunit` dependency, so it will execute in parallel with (or regardless of) the `phpunit` matrix. If tests are failing, this wastes a runner slot and can produce misleading coverage output for a broken build. Adding `needs: [phpunit]` would keep coverage reporting gated on a green test run.

Reviews (1): Last reviewed commit: "chore: update PHP CI workflow" | Re-trigger Greptile

Comment thread .github/workflows/php.yml
@marandaneto marandaneto marked this pull request as ready for review June 11, 2026 16:41
@marandaneto marandaneto requested a review from a team as a code owner June 11, 2026 16:41
@greptile-apps

greptile-apps Bot commented Jun 11, 2026

Copy link
Copy Markdown

Reviews (2): Last reviewed commit: "chore: address PHP CI feedback" | Re-trigger Greptile

@dustinbyrne dustinbyrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

codeql warnings are worth addressing

@marandaneto

Copy link
Copy Markdown
Member Author

codeql warnings are worth addressing

Which ones? I dont see any as comments

@marandaneto marandaneto merged commit ae13eaa into main Jun 12, 2026
21 checks passed
@marandaneto marandaneto deleted the chore/update-php-ci-workflow branch June 12, 2026 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants