chore: update PHP CI workflow#162
Merged
Merged
Conversation
Prompt To Fix All With AIFix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
.github/workflows/php.yml:64-80
**Coverage runs even when tests fail**
The `coverage` job has no `needs: phpunit` dependency, so it will execute in parallel with (or regardless of) the `phpunit` matrix. If tests are failing, this wastes a runner slot and can produce misleading coverage output for a broken build. Adding `needs: [phpunit]` would keep coverage reporting gated on a green test run.
Reviews (1): Last reviewed commit: "chore: update PHP CI workflow" | Re-trigger Greptile |
|
Reviews (2): Last reviewed commit: "chore: address PHP CI feedback" | Re-trigger Greptile |
dustinbyrne
approved these changes
Jun 11, 2026
dustinbyrne
left a comment
Contributor
There was a problem hiding this comment.
codeql warnings are worth addressing
Member
Author
Which ones? I dont see any as comments |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
Keep the PHP CI workflow aligned with project metadata changes, reduce wasted CI work, and separate regular test runs from coverage collection.
💚 How did you test it?
composer validate --no-check-lock --no-check-version --strict📝 Checklist
If releasing new changes
pnpm changesetto generate a changeset file