Skip to content

ci: shadow typecheck/unit/integration jobs on Blacksmith #1744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gantoine wants to merge 3 commits into
base: main
Choose a base branch
from
Open

ci: shadow typecheck/unit/integration jobs on Blacksmith #1744

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
13f150e
ci: shadow typecheck/unit/integration jobs on Blacksmith
gantoine Apr 20, 2026
37d8980
ci: scope pnpm store cache to matrix.runner
gantoine Apr 21, 2026
760791c
ci: add explicit job names to preserve required check names
Copilot Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 45 additions & 9 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,13 @@ concurrency:

jobs:
unit-test:
runs-on: ubuntu-latest
name: ${{ matrix.runner == 'ubuntu-latest' && 'unit-test' || format('unit-test ({0})', matrix.runner) }}
strategy:
fail-fast: false
matrix:
runner: ${{ fromJSON(vars.BLACKSMITH_SHADOW_ENABLED == 'true' && '["ubuntu-latest","blacksmith-4vcpu-ubuntu-2404"]' || '["ubuntu-latest"]') }}
runs-on: ${{ matrix.runner }}
continue-on-error: ${{ matrix.runner != 'ubuntu-latest' }}
Comment thread
gantoine marked this conversation as resolved.
permissions:
contents: read
steps:
Expand All @@ -25,7 +31,19 @@ jobs:
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
with:
node-version: 22
cache: "pnpm"

- name: Get pnpm store directory
id: pnpm-store
shell: bash
run: echo "path=$(pnpm store path --silent)" >> "$GITHUB_OUTPUT"

- name: Cache pnpm store
uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830 # v4
with:
path: ${{ steps.pnpm-store.outputs.path }}
key: pnpm-store-${{ matrix.runner }}-${{ hashFiles('pnpm-lock.yaml') }}
restore-keys: |
pnpm-store-${{ matrix.runner }}-

- name: Install dependencies
run: pnpm install --frozen-lockfile
Expand All @@ -37,7 +55,13 @@ jobs:
run: pnpm test

integration-test:
runs-on: macos-latest
name: ${{ matrix.runner == 'macos-latest' && 'integration-test' || format('integration-test ({0})', matrix.runner) }}
strategy:
fail-fast: false
matrix:
runner: ${{ fromJSON(vars.BLACKSMITH_SHADOW_ENABLED == 'true' && '["macos-latest","blacksmith-6vcpu-macos-latest"]' || '["macos-latest"]') }}
runs-on: ${{ matrix.runner }}
continue-on-error: ${{ matrix.runner != 'macos-latest' }}
Comment thread
gantoine marked this conversation as resolved.
Comment on lines +59 to +64
Copy link

Copilot AI Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as for unit-test: without an explicit job name, the matrix-expanded check will typically show up as integration-test (runner: …), not integration-test (macos-latest). Consider adding a name that includes matrix.runner so required check names are clear and match the PR’s guidance.

Copilot uses AI. Check for mistakes.
permissions:
contents: read
steps:
Expand All @@ -53,24 +77,36 @@ jobs:
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
with:
node-version: 22
cache: "pnpm"

- name: Get pnpm store directory
id: pnpm-store
shell: bash
run: echo "path=$(pnpm store path --silent)" >> "$GITHUB_OUTPUT"

- name: Cache pnpm store
uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830 # v4
with:
path: ${{ steps.pnpm-store.outputs.path }}
key: pnpm-store-${{ matrix.runner }}-${{ hashFiles('pnpm-lock.yaml') }}
restore-keys: |
pnpm-store-${{ matrix.runner }}-

- name: Cache Playwright browsers
uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830 # v4
id: playwright-cache
with:
path: ~/Library/Caches/ms-playwright
key: playwright-${{ runner.os }}-${{ hashFiles('pnpm-lock.yaml') }}
key: playwright-${{ matrix.runner }}-${{ hashFiles('pnpm-lock.yaml') }}
restore-keys: |
playwright-${{ runner.os }}-
playwright-${{ matrix.runner }}-

- name: Cache Electron binary
uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830 # v4
with:
path: ~/Library/Caches/electron
key: electron-${{ runner.os }}-${{ hashFiles('pnpm-lock.yaml') }}
key: electron-${{ matrix.runner }}-${{ hashFiles('pnpm-lock.yaml') }}
restore-keys: |
electron-${{ runner.os }}-
electron-${{ matrix.runner }}-

- name: Install dependencies
run: pnpm install --frozen-lockfile
Expand Down Expand Up @@ -103,7 +139,7 @@ jobs:

- name: Upload Playwright report
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4
if: failure()
if: failure() && matrix.runner == 'macos-latest'
with:
name: playwright-report
path: apps/code/playwright-report/
Expand Down
22 changes: 20 additions & 2 deletions .github/workflows/typecheck.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,13 @@ concurrency:

jobs:
typecheck:
runs-on: ubuntu-latest
name: ${{ matrix.runner == 'ubuntu-latest' && 'typecheck' || format('typecheck ({0})', matrix.runner) }}
strategy:
fail-fast: false
matrix:
runner: ${{ fromJSON(vars.BLACKSMITH_SHADOW_ENABLED == 'true' && '["ubuntu-latest","blacksmith-4vcpu-ubuntu-2404"]' || '["ubuntu-latest"]') }}
runs-on: ${{ matrix.runner }}
continue-on-error: ${{ matrix.runner != 'ubuntu-latest' }}
Comment thread
gantoine marked this conversation as resolved.
permissions:
contents: read
steps:
Expand All @@ -25,7 +31,19 @@ jobs:
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
with:
node-version: 22
cache: "pnpm"

- name: Get pnpm store directory
id: pnpm-store
shell: bash
run: echo "path=$(pnpm store path --silent)" >> "$GITHUB_OUTPUT"

- name: Cache pnpm store
uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830 # v4
with:
path: ${{ steps.pnpm-store.outputs.path }}
key: pnpm-store-${{ matrix.runner }}-${{ hashFiles('pnpm-lock.yaml') }}
restore-keys: |
pnpm-store-${{ matrix.runner }}-

- name: Install dependencies
run: pnpm install --frozen-lockfile
Expand Down