Adds 'Condition:CanWither' flag to numerous skills and supports#1809
Open
krryan wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Open
Adds 'Condition:CanWither' flag to numerous skills and supports#1809krryan wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
krryan wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Conversation
Author
|
I attempted to add unit tests for this, but couldn’t figure out how to test that the config was shown. I was using but I think I need to run something in between these two to get the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
The “# of Wither Stacks” config was not enabled by Chaos Bolt, His Foul Emergence, Withering Presence, Withering Touch, Wither Away, or The Right Hand of Darkness.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pobb.in/RRWhH42PJV3X
(Not that there’s much point, just add any of the skills or take any of the nodes listed here.)
Before screenshot:
After screenshot: