Functional enhancements, new options for sections and tags, thumbnailUrl, metadata customization#1
Open
ndewhurst wants to merge 8 commits into
Open
Functional enhancements, new options for sections and tags, thumbnailUrl, metadata customization#1ndewhurst wants to merge 8 commits into
ndewhurst wants to merge 8 commits into
Conversation
- Refactoring _parsely_get_tags for performance (particularly when large vocabs are involved) and simplicity. - Tweaking syntax in parsely_should_add_metas to avoid fatal error in some PHP versions.
…section. Admins can now specify criteria for choosing between multiple terms in the given vocab, and can elect to always use top-level terms in hierarchical vocabs.
New config section for metadata values, with node/global token support. Current iteration supports the "thumbnailUrl" field. Future iterations should support the custom "metadata" option, "@type," etc. (possibly all fields). Works gracefully with any recent version of Token module, or without it.
Author
|
I just added support for the thumbnailUrl field, with nice CMS configurability. It ties into the Token module if it's available so admins can drop in a token for a node image field, etc. (see 2be2259 for specifics). The idea is that we could take the same approach for some or all of the other metadata fields, to make this truly customizable. Can also support the alternate metadata format ("repeated metatags") or just pipe data from the Metatag module into the JSON-LD format. And we'd want to make the final product alterable in any case... |
ndewhurst
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Mike,
I'm working on a pilot parse.ly integration with a Drupal site, and would like to use this module, so I started extending/revising it. Let me know if you have any thoughts on these changes (and/or if you have a development roadmap for an initial module release).
Cheers,
Nathanael