UI enhancements#19
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request focuses on two main improvements to the add-book workflow: preserving the modal backdrop when transitioning from the add-book choice sheet to the digital import UI, and unifying the shapes of the action buttons in the import success state. It also introduces new and enhanced widget tests to ensure these UI behaviors remain robust and verifiable.
Modal Backdrop Continuity and UI Consistency Enhancements:
Add-book modal and import flow:
AddBookChoiceSheetfrom aStatelessWidgetto aStatefulWidget, allowing it to swap its content between the choice options and theImportBookSheetwithout closing the modal. This ensures the modal backdrop and route are preserved when transitioning to the digital import UI. (app/lib/widgets/add_book/add_book_choice_sheet.dart) [1] [2] [3]app/lib/widgets/add_book/add_book_choice_sheet.dart)ImportBookSheet reusability and testability:
ImportBookSheet.withInitialResultto allow deterministic rendering of the import success state in widget tests. The import sheet now accepts initial state and result parameters for flexible instantiation. (app/lib/widgets/add_book/import_book_sheet.dart) [1] [2]app/lib/widgets/add_book/import_book_sheet.dart)UI polish and accessibility:
StadiumBorder(pill-shaped) styles to both the "Pick different file" (OutlinedButton) and "Add to library" (FilledButton) actions in the import success UI, ensuring visual consistency and accessibility. Also improved their disabled-state color handling and added a progress indicator for the commit action. (app/lib/widgets/add_book/import_book_sheet.dart)Testing and regression coverage:
app/test/widgets/add_book/add_book_sheets_test.dart) [1] [2]app/test/widgets/add_book/add_book_sheets_test.dart)Documentation and implementation plans:
docs/superpowers/plans/2026-07-14-add-book-backdrop-continuity.md,docs/superpowers/plans/2026-07-14-import-action-button-shapes.md) [1] [2]