Add cft#653
Draft
andrew-fleming wants to merge 25 commits into
Draft
Conversation
PR OpenZeppelin#620 moved every unit suite to the async, backend-aware @openzeppelin/compact-simulator@0.2.0 API, but the ElGamal suite added on this branch still used the synchronous createSimulator path. Against 0.2.0 the spec fails to load (TypeError: Cannot read properties of undefined reading 'kind'), which is the only failing suite in the test workflow on OpenZeppelin#617. * ElGamalSimulator: drop the sync constructor for `static async create`, add `artifactName: 'MockElGamal'`, and return `Promise<R>` from every pure pass-through (the assert circuits return `Promise<[]>`). * ElGamal.test.ts: build the simulator in `beforeAll`, derive the shared keys once, await every circuit call, and assert failure paths with `await expect(...).rejects.toThrow(...)`. No behavioral change to the contract; the migration is mechanical and mirrors the UtilsSimulator / utils.test.ts pattern from OpenZeppelin#620.
test(crypto): migrate ElGamal suite to async simulator
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.