fix(spp_graduation): expose Graduation Criteria via menu + standalone views#190
fix(spp_graduation): expose Graduation Criteria via menu + standalone views#190emjay0921 wants to merge 3 commits into
Conversation
… views The model `spp.graduation.criteria` shipped with the module along with ACL entries and the `criteria_ids` One2many on `spp.graduation.pathway`, but had no menu, no action_window, and no standalone list/form views. Users could only edit criteria indirectly through the embedded list on the pathway form — the documented `Graduation > Graduation Criteria` nav path resolved to nothing. - Add `views/graduation_criteria_views.xml` with list, form, and search views plus an `action_graduation_criteria` action_window. The search view groups by pathway and assessment_method, filters required vs optional, and surfaces the archived flag. - Wire a `Graduation Criteria` menuitem as a direct child of `menu_graduation_root` (sequence 20, between Assessments and Configuration), gated on `group_spp_graduation_user` per the OP suggested fix. - Bump 19.0.2.0.0 → 19.0.2.0.1 + HISTORY entry. Refs OP#990.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 19.0 #190 +/- ##
==========================================
+ Coverage 71.69% 71.73% +0.04%
==========================================
Files 942 942
Lines 55561 55600 +39
==========================================
+ Hits 39835 39886 +51
+ Misses 15726 15714 -12
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Code Review
This pull request introduces a user interface for managing graduation criteria by adding search, list, and form views for the spp.graduation.criteria model. It also includes a new menu item and action to make these criteria accessible to users. The module version has been incremented to 19.0.2.0.1, and the history file has been updated accordingly. I have no feedback to provide.
|
@gonzalesedwin1123 — ready for review. QA on OP#990 already passed; latest commit |
Why is this change needed?
The
spp.graduation.criteriamodel shipped with the module along with ACL entries and thecriteria_idsOne2many onspp.graduation.pathway, but had no menu, no action_window, and no standalone list/form views. Users could only edit criteria indirectly through the embedded list on the pathway form — the documentedGraduation > Graduation Criterianav path resolved to nothing.Refs OP#990.
How was the change implemented?
1. New view file
spp_graduation/views/graduation_criteria_views.xml: list, form, and search views plus anaction_graduation_criteriaaction_window. The search view groups by pathway and assessment method, filters required vs optional, and surfaces the archived flag.2. Menu wiring in
views/graduation_menus.xml: newmenu_graduation_criteriaas a direct child ofmenu_graduation_root(sequence 20, between Assessments and Configuration), gated ongroup_spp_graduation_userper the OP's suggested fix.3. Manifest + HISTORY: new view file added to the data list, version bumped 19.0.2.0.0 → 19.0.2.0.1.
New unit tests
None — pure view/menu wiring; no model changes.
Unit tests executed by the author
Manual verification on a running instance: upgraded
spp_graduation, confirmed the new "Graduation Criteria" menu appears as a direct child of Graduation (between Assessments and Configuration), opened the list/form, created a record, exercised the Required / Optional / Archived filters and the Group By options, and verified the existingweight > 0ValidationError still fires from the form.How to test manually
spp_graduation(XML-only round, no full reset needed).Weight must be greater than zerovalidation fires.Related links
OP#990 — QA passed Round 1.