-
Notifications
You must be signed in to change notification settings - Fork 31
fix: Unexpected response received: Status 200 Content-Type video/mp4 #363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ivo-stratev-frontierteams
wants to merge
1
commit into
OpenRouterTeam:main
Choose a base branch
from
ivo-stratev-frontierteams:fix/video_generation_content_type_video_mp4
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[suggestion]
video_generation.py— this file is Speakeasy-generated (DO NOT EDIT); a direct edit will be reverted on the nextspeakeasy runDetails
Why: The file header reads
"""Code generated by Speakeasy (https://speakeasy.com). DO NOT EDIT."""and the repo CONTRIBUTING.md states "we do not accept direct changes or pull requests" and "fixes will be included in the next generation of the generated code." The.speakeasy/out.openapi.yamlspec only declaresapplication/octet-streamas the 200 response media type forGET /videos/{jobId}/content(line 31700). Whenspeakeasy runis run again, it will regenerate this file from the spec and overwrite both the Accept header change and thevideo/mp4match-response block.The correct approach is one of:
.speakeasy/out.openapi.yamlto addvideo/mp4as a valid 200 response content type alongsideapplication/octet-stream, then re-runspeakeasy runto regenerate the SDK. This produces a verified fix that survives future codegen runs..speakeasy/in.openapi.yaml) and apply the fix via a Speakeasy overlay, letting the SDK regenerate from source.The fix logic itself is correct — Accept header update plus symmetric match_response checks on both sync and async variants — so the fix needs a codegen-compatible home, not code changes.
Prompt for agents
Reviewed at
d9de7a9