Conversation
- 在 Thunder 请求入口将空 token 转为普通错误 - 避免刷新或登录失败后写入 nil token - 为 Thunder 相关驱动补充空 token 回归测试 Co-authored-by: Codex <267193182+codex@users.noreply.github.com> Signed-off-by: jyxjjj <16695261+jyxjjj@users.noreply.github.com>
This was
linked to
issues
Jun 16, 2026
Closed
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the Thunder-family storage drivers (Thunder, ThunderX, Thunder Browser) against nil-token scenarios so token loss/refresh failures no longer trigger nil-pointer panics during request authorization, allowing storage initialization to fail gracefully without taking down the process.
Changes:
- Add early
errs.EmptyTokenreturns inRequestwhen the in-memory token is missing (TokenResp == nil). - Prevent writing/using
niltokens after refresh/login attempts by returning early whentoken == nil. - Add regression tests ensuring
Requestreturnserrs.EmptyTokenwhen invoked without a token.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| drivers/thunderx/driver.go | Adds nil-guards around token usage and returns errs.EmptyToken when token is missing in Request. |
| drivers/thunderx/driver_test.go | Regression test for missing-token Request behavior. |
| drivers/thunder/driver.go | Adds nil-guards in refresh flow and returns errs.EmptyToken when token is missing in Request. |
| drivers/thunder/driver_test.go | Regression test for missing-token Request behavior. |
| drivers/thunder_browser/driver.go | Adds errs import and missing-token handling in Request, plus refresh-flow nil-guard. |
| drivers/thunder_browser/driver_test.go | Regression test for missing-token Request behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary / 摘要
errs.EmptyToken普通错误,让存储加载按现有失败状态处理并继续加载其他驱动。niltoken,并补充 Thunder、ThunderX、Thunder Browser 的回归测试。/ 此 PR 包含破坏性变更。
/ 此 PR 修改了公开 API、配置、存储格式或迁移行为。
/ 此 PR 需要关联仓库同步修改。
Related repository PRs / 关联仓库 PR:
Related Issues / 关联 Issue
Fixes #2467
Fixes #2571
Fixes #2567
Testing / 测试
go test ./...Checklist / 检查清单
/ 我已阅读 CONTRIBUTING。
/ 我确认此贡献符合仓库许可证、贡献规范和行为准则。
gofmt,go fmt, orprettierwhere applicable./ 我已按适用情况使用
gofmt、go fmt或prettier格式化变更代码。/ 我已在适用情况下请求相关维护者或代码所有者审查。
AI Disclosure / AI 使用声明
/ 此 PR 包含 AI 辅助内容。
Tools used / 使用工具:
Usage scope / 使用范围:
Code generation / 代码生成
Refactoring / 重构
Documentation / 文档
Tests / 测试
Translation / 翻译
Review assistance / 审查辅助
I have reviewed and validated all AI-assisted content included in this PR.
/ 我已审核并验证此 PR 中的所有 AI 辅助内容。
I have ensured that all AI-assisted commits include
Co-Authored-Byattribution./ 我已确保所有 AI 辅助提交都包含
Co-Authored-By归属信息。I can reproduce all AI-assisted content included in this PR without any AI tools.
/ 我可以在没有任何 AI 工具的情况下重现此 PR 中包含的 AI 辅助内容。