Fix v2 sync#1425
Merged
Merged
Conversation
Collaborator
Author
|
I'll have to test this against sync in production:
|
Collaborator
Author
|
v2 still fails to deploy :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short Description
Fix v2 GH deploy
Fixes #1422
Implementation Details
I've been trying to fix this on the assumption that the API key was somehow not being set on redirect.
But that's wrong! The problem actually is the endpoint.
This PR:
Testing this stuff is so hard and I'm paying the price of not having better testing earlier. I've added a few new tests here to try and cover us. I'd really like to spend a day on this, but can't justify it.
AI Usage
Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):
You can read more details in our
Responsible AI Policy