Skip to content

Fix v2 sync#1425

Merged
josephjclark merged 7 commits into
mainfrom
fix-v2-deploy
May 26, 2026
Merged

Fix v2 sync#1425
josephjclark merged 7 commits into
mainfrom
fix-v2-deploy

Conversation

@josephjclark
Copy link
Copy Markdown
Collaborator

@josephjclark josephjclark commented May 26, 2026

Short Description

Fix v2 GH deploy

Fixes #1422

Implementation Details

I've been trying to fix this on the assumption that the API key was somehow not being set on redirect.

But that's wrong! The problem actually is the endpoint.

This PR:

  • refactors the redirect code to be cleaner and easier to manage
  • Fixes tracking of endpoint through pull and deploy
  • Adds unit tests on pull to ensure that endpoint is set
  • Adds an integration test for deploy

Testing this stuff is so hard and I'm paying the price of not having better testing earlier. I've added a few new tests here to try and cover us. I'd really like to spend a day on this, but can't justify it.

AI Usage

Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):

  • I have used Claude Code
  • I have used another model
  • I have not used AI

You can read more details in our
Responsible AI Policy

@github-project-automation github-project-automation Bot moved this to New Issues in Core May 26, 2026
@josephjclark
Copy link
Copy Markdown
Collaborator Author

I'll have to test this against sync in production:

  • Can pull in v1
  • Can commit and deploy in v1
  • Can pull in v2
  • Can commit and deploy in v2

@josephjclark josephjclark merged commit 4d9e6fd into main May 26, 2026
7 checks passed
@github-project-automation github-project-automation Bot moved this from New Issues to Done in Core May 26, 2026
@josephjclark josephjclark deleted the fix-v2-deploy branch May 26, 2026 15:17
@josephjclark
Copy link
Copy Markdown
Collaborator Author

v2 still fails to deploy :(

@josephjclark josephjclark mentioned this pull request May 26, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

v2 GH sync is broken

2 participants