Skip to content

[projmgr] MLOps: make it tolerant to missing hardware or simulator targets#2474

Merged
brondani merged 2 commits into
mainfrom
projmgr-rework-mlops
May 13, 2026
Merged

[projmgr] MLOps: make it tolerant to missing hardware or simulator targets#2474
brondani merged 2 commits into
mainfrom
projmgr-rework-mlops

Conversation

@brondani
Copy link
Copy Markdown
Collaborator

@brondani brondani commented May 11, 2026

Fixes

If there is no Arm-FVP target, just don’t output the simulator: node in the *.cbuild-mlops.yml
Likewise when there is no hardware target, the hardware: node should be not present (this allows to target initially pure simulation).
Don’t stop conversion with such an error:
csolution error: mlops: simulator target with debugger 'Arm-FVP' not found
There is no user notification required when hardware: or simulator: node is missing.

Changes

  • When simulator or hardware targets are not explicitly specified, accept if their default values cannot be determined: in such case do not emit the related sections in cbuild-mlops.yml and do not throw error messages.
  • Refactors MLOps target/target-set resolution to allow “missing default” hardware/simulator without failing generation.
  • Update test cases

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 11, 2026

Test Results

    3 files   -    55     21 suites   - 155   17m 34s ⏱️ - 6m 16s
  463 tests  -   451    463 ✅  -   434  0 💤  - 17  0 ❌ ±0 
1 389 runs   - 1 490  1 389 ✅  - 1 422  0 💤  - 68  0 ❌ ±0 

Results for commit a5af619. ± Comparison against base commit e673230.

This pull request removes 451 tests.
AuxCmdTests ‑ MkdirCmdTest
AuxCmdTests ‑ RmdirCmdTest
AuxCmdTests ‑ TouchCmdTest
BuildSystemGeneratorTests ‑ GenAuditFile
BuildSystemGeneratorTests ‑ GenAuditFile_WithOut_Existing_Audit_File
BuildSystemGeneratorTests ‑ GenAuditFile_With_Existing_Audit_File
BuildSystemGeneratorTests ‑ GetString
BuildSystemGeneratorTests ‑ StrConv
BuildSystemGeneratorTests ‑ StrNorm
CBuildGCCTests ‑ Asm
…

♻️ This comment has been updated with latest results.

@brondani brondani force-pushed the projmgr-rework-mlops branch 5 times, most recently from 3a64ab0 to 86841f6 Compare May 13, 2026 07:49
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts ProjMgr’s MLOps (cbuild-mlops) generation to be tolerant when a default hardware or simulator target cannot be determined, avoiding errors and omitting the corresponding YAML sections, and updates the unit tests/test data accordingly.

Changes:

  • Refactors MLOps target/target-set resolution to allow “missing default” hardware/simulator without failing generation.
  • Updates/extends unit tests to cover missing hardware/simulator scenarios and revised error messages.
  • Updates MLOps test csolution fixtures to align with the new target resolution behavior.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tools/projmgr/src/ProjMgrMlops.cpp Adds tolerant target-set resolution and conditional emission of hardware/simulator-derived settings.
tools/projmgr/include/ProjMgrMlops.h Updates MLOps helper method signatures to support new resolution logic (std::optional-based).
tools/projmgr/test/src/ProjMgrUnitTests.cpp Extends MLOps unit tests for missing hardware/simulator targets and adjusts expected failures.
tools/projmgr/test/data/MLOps/no_hardware.csolution.yml New fixture covering “simulator-only” target-types for MLOps generation.
tools/projmgr/test/data/MLOps/no_simulator.csolution.yml Updates fixture covering “hardware-only” target-types for MLOps generation.
tools/projmgr/test/data/MLOps/minimal.csolution.yml Updates minimal fixture (removes simulator define) to match current expectations.
tools/projmgr/test/data/MLOps/failure2.csolution.yml Updates failure case fixture to match new target syntax/error message.
tools/projmgr/test/data/MLOps/failure3.csolution.yml Updates failure case fixture to match new error condition and message.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tools/projmgr/src/ProjMgrMlops.cpp
Comment thread tools/projmgr/src/ProjMgrMlops.cpp
Comment thread tools/projmgr/include/ProjMgrMlops.h
@brondani brondani marked this pull request as ready for review May 13, 2026 08:26
@brondani brondani requested a review from soumeh01 May 13, 2026 08:26
@codecov
Copy link
Copy Markdown

codecov Bot commented May 13, 2026

Codecov Report

❌ Patch coverage is 77.27273% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.18%. Comparing base (e673230) to head (a5af619).

Files with missing lines Patch % Lines
tools/projmgr/src/ProjMgrMlops.cpp 77.27% 3 Missing and 12 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2474   +/-   ##
=======================================
  Coverage   65.17%   65.18%           
=======================================
  Files         147      147           
  Lines       26621    26633   +12     
  Branches    16128    16140   +12     
=======================================
+ Hits        17351    17361   +10     
- Misses       7070     7072    +2     
  Partials     2200     2200           
Flag Coverage Δ
projmgr-cov 87.85% <77.27%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tools/projmgr/src/ProjMgrMlops.cpp 80.23% <77.27%> (+0.23%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@brondani brondani merged commit af2c644 into main May 13, 2026
33 checks passed
@brondani brondani deleted the projmgr-rework-mlops branch May 13, 2026 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants