Classify Windows TCP connect timeout as a network error#709
Open
Classify Windows TCP connect timeout as a network error#709
Conversation
On Windows 2019, connecting to a port with no listener can result in a connection timeout rather than an immediate RST, producing the message "The client was unable to establish the initial connection within the timeout". This string was missing from the IsNetworkError recogniser, causing it to fall through to UnknownError on Windows CI runs. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IsNetworkErrorrecogniser inExceptionReturnedByHalibutProxyExtensionMethod.cs, causing it to fall through toUnknownErrorinstead ofIsNetworkError.Test plan
ExceptionReturnedByHalibutProxyExtensionMethodFixture— all 24 tests pass locally (verified before commit)BecauseTheProxyIsNotResponding_TheExceptionShouldBeANetworkErrorandWhenTheConnectionTerminatesWaitingForAResponsefailures seen in nightly builds 4709 and 4710Identified via analysis of two consecutive failing nightly builds on Windows 2019 (
8.1.4709and8.1.4710).🤖 Generated with Claude Code