integration: consolidate #593, #594, #595, #597 (x402 402-page, OpenAPI, buy-x402 --set-default, verifier streaming)#598
Closed
bussyjd wants to merge 13 commits into
Closed
integration: consolidate #593, #594, #595, #597 (x402 402-page, OpenAPI, buy-x402 --set-default, verifier streaming)#598bussyjd wants to merge 13 commits into
bussyjd wants to merge 13 commits into
Conversation
…l> as primary After a persistent inference buy publishes paid/<remote-model> in LiteLLM, the agent adopts it as its own primary chat model in-pod via native 'hermes config set model.default' (atomic write, per-request re-read, no restart, no host CLI, no new RBAC). Includes a LiteLLM /v1/models existence guard, an auto-refill safety warning, and a PyYAML fallback writer. Validated by a design+adversarial workflow and a live CLI smoke against a running obol-agent: buy --set-default flips config.yaml model.default to paid/AEON-7/... and the next agent chat settled via the x402-buyer pool (spent 0->1) with no restart; rollback verified.
# Conflicts: # internal/hermes/hermes.go
The /api OpenAPI reference is served over the public tunnel and pulls the @scalar/api-reference bundle from jsdelivr. The integrity hash was left empty in phase 1, so the browser executed whatever the CDN returned, unverified. Populate scalarBundleSRI with the sha384 of the pinned 1.34.0 bundle so a tampered CDN response is blocked. Comment updated to stress the hash must be re-derived in lockstep with every scalarBundleVersion bump.
…arning The 'paid/<model> not selectable in LiteLLM' guard ran *after* the no-auto-refill WARNING. A model that LiteLLM would refuse still printed a scary 'every chat turn fails when the pool empties' warning describing a primary-model failure mode that cannot occur when the default was never switched. Reorder so we refuse first and only warn when we are actually about to adopt the model.
…e commands spec.model.name and metadata.name flow from the ServiceOffer CR into copy-pasteable 'obol buy inference ...' commands rendered on the public 402 page. A hostile or fat-fingered offer could smuggle shell metacharacters into a command a reader might paste. Add sanitizeDisplayToken at the render boundary: CR-sourced tokens must match the model-id/k8s-name charset (^[A-Za-z0-9._:/-]+$) or collapse to the existing safe placeholder. Real ids like qwen3.5:9b and anthropic/claude-3-5-sonnet-latest pass through unchanged.
This was referenced Jun 5, 2026
review fixes for #598: Scalar SRI pin, buy-x402 guard order, 402 token sanitization
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integration branch consolidating PRs ≥ #593
This branch consolidates four open PRs into a single reviewable diff on top of
main:oisin/402-html-pageoisin/openapi/apireference for offered servicesfeat/buy-x402-set-default--set-default— agent self-adoptspaid/<model>as primaryoisin/streamingFlush/Hijack) to keep the tunnel aliveMerge order & conflicts
Merged
#593 → #595 → #597 → #594. One conflict, ininternal/hermes/hermes.go(#594 was branched from a base predating51fd708's deployment-strategy migration). Resolved net-zero vsorigin/main— kept main's imperativemigrateDeploymentStrategy;go test ./internal/hermes/passes.Verification
go build ./...cleango test ./...)fix/integration-593plus-review).Disposition of source PRs
#593, #594, #595, #597 are superseded by this branch and closed in favour of this consolidated review.