Skip to content

Fix: Narrow except Exception to except SQLAlchemyError in health_check() #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Bornunique911 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix: Narrow except Exception to except SQLAlchemyError in health_check() #941

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cef6111
Added import for SQLAlchemyError and narrow exception handler in heal…
Bornunique911 Jun 20, 2026
a401550
Fixed linting issues
Bornunique911 Jun 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions application/database/db.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
from flask_sqlalchemy.model import DefaultMeta
from sqlalchemy import func, delete, cast as sql_cast, literal, or_
from sqlalchemy.dialects.postgresql import JSONB
from sqlalchemy.exc import OperationalError, IntegrityError
from sqlalchemy.exc import OperationalError, IntegrityError, SQLAlchemyError

from neomodel import (
config,
Expand Down Expand Up @@ -2289,7 +2289,7 @@ def health_check(self) -> Dict[str, Any]:
"db_reachable": False,
"reason": "database unreachable",
}
except Exception: # pragma: no cover - defensive, never fail open
except SQLAlchemyError: # pragma: no cover - defensive, never fail open
return {
"ok": False,
"db_reachable": False,
Expand Down
Loading